This revision was automatically updated to reflect the committed changes.
Closed by commit rL367323: [COFF][ARM64] Reorder handling of aarch64 MSVC
builtins (authored by dmajor, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/CodeGen/CGBuiltin.cpp:8182
switch (BuiltinID) {
default: return nullptr;
case NEON::BI__builtin_neon_vbsl_v:
dmajor wrote:
dmajor marked an inline comment as done.
dmajor added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:8182
switch (BuiltinID) {
default: return nullptr;
case NEON::BI__builtin_neon_vbsl_v:
efriedma wrote:
> I'm a little concerned about the
efriedma added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:8182
switch (BuiltinID) {
default: return nullptr;
case NEON::BI__builtin_neon_vbsl_v:
I'm a little concerned about the overall code structure here; even if moving
the code for the
dmajor created this revision.
dmajor added reviewers: mgrang, efriedma, hans.
Herald added subscribers: kristina, jfb, kristof.beyls, javed.absar.
Herald added a project: clang.
In `CodeGenFunction::EmitAArch64BuiltinExpr()`, bulk move of all of the aarch64
MSVC-builtin cases to an earlier point
