This revision was automatically updated to reflect the committed changes.
Closed by commit rL367301: [AArch64] Disable __ARM_FEATURE_SVE without ACLE.
(authored by s.desmalen, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
I see, makes sense. LGTM, thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65404/new/
https://reviews.llvm.org/D65404
___
sdesmalen added a comment.
Thanks, I see your argument for having the feature enabled even when the ACLE
is still partially supported. At the moment however, LLVM still only support
the assembler/disassembler and inline asm.
We'll be working to add support for the ACLE soon, but for now having
rengolin added a comment.
I understand (and agree with) the reasoning of this patch, but wouldn't this
also make it harder to test the current behaviour?
I mean, LLVM doesn't support officially SVE entirely, so there's no point in
expecting anything to work for now. What is the coverage of the
sdesmalen created this revision.
sdesmalen added reviewers: c-rhodes, chill, rengolin, rovka.
Herald added subscribers: kristof.beyls, tschuett, javed.absar.
The Arm C Language Extensions for SVE document specifies that
__ARM_FEATURE_SVE should be set when the compiler supports SVE and
