[PATCH] D65527: Avoid assemble step in verbose-output-quoting.c

2019-09-04 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL370928: Avoid assemble step in verbose-output-quoting.c (authored by yuanfang, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65527: Avoid assemble step in verbose-output-quoting.c

2019-09-04 Thread Hans Wennborg via Phabricator via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks good to me. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65527/new/ https://reviews.llvm.org/D65527

[PATCH] D65527: Avoid assemble step in verbose-output-quoting.c

2019-09-03 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen updated this revision to Diff 218588. ychen added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65527/new/ https://reviews.llvm.org/D65527 Files: clang/test/Driver/verbose-output-quoting.c Index:

[PATCH] D65527: Avoid assemble step in verbose-output-quoting.c

2019-09-03 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen added a comment. > Would that work for this test also? Yes, that sounds good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65527/new/ https://reviews.llvm.org/D65527 ___ cfe-commits mailing

[PATCH] D65527: Avoid assemble step in verbose-output-quoting.c

2019-08-01 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. Sorry, I should have caught this in the original review. Normally tests in Driver/ use the -### flag. That way it doesn't invoke the frontend at all, it just shows how it would invoke it. Would that work for this test also? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D65527: Avoid assemble step in verbose-output-quoting.c

2019-07-31 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen created this revision. ychen added a reviewer: hans. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65527 Files: clang/test/Driver/verbose-output-quoting.c Index: