This revision was automatically updated to reflect the committed changes.
Closed by commit rL368206: [clang-doc] Parallelize reducing phase (authored by
DiegoAstiazaran, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
DiegoAstiazaran updated this revision to Diff 213986.
DiegoAstiazaran marked an inline comment as done.
DiegoAstiazaran added a comment.
Add comment
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65628/new/
https://reviews.llvm.org/D65628
Files:
juliehockett accepted this revision.
juliehockett added a comment.
This revision is now accepted and ready to land.
LGTM (after comment nit addressed)
Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:249
+ Error = false;
+ llvm::ThreadPool
DiegoAstiazaran added inline comments.
Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:72
+static llvm::cl::opt ThreadCount(
+"thread-count",
juliehockett wrote:
> Can we use the pre-existing concurrency flag instead
>
DiegoAstiazaran updated this revision to Diff 213968.
DiegoAstiazaran marked 2 inline comments as done.
DiegoAstiazaran added a comment.
Use pre-existing concurrency flag `--execute-concurrency` instead implementing
a new one.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65628/new/
juliehockett added inline comments.
Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:72
+static llvm::cl::opt ThreadCount(
+"thread-count",
Can we use the pre-existing concurrency flag instead
DiegoAstiazaran updated this revision to Diff 213425.
DiegoAstiazaran marked 2 inline comments as done.
DiegoAstiazaran added a comment.
Herald added a subscriber: jfb.
Fix atomicity issues.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65628/new/
https://reviews.llvm.org/D65628
jakehehrlich added a comment.
LGTM other than a couple atomicity issues.
Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:244
+ llvm::errs() << toString(ReadInfos.takeError()) << "\n";
+ Error = true;
+ return;
use
DiegoAstiazaran created this revision.
DiegoAstiazaran added reviewers: jakehehrlich, juliehockett.
DiegoAstiazaran added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman.
Reduce phase has been parallelized and a execution time was reduced by 60% with
this.
The reading
