[PATCH] D65637: [clangd] [WIP] Semantic highlighting prototype for the vscode extension.

hokein added a comment. In D65637#1613692 , @nridge wrote: > Do you plan to support text decoration options other than color, e.g. bold / > underline / italic? I think we'd just support color, and we don't have further plan to support richer

[PATCH] D65637: [clangd] [WIP] Semantic highlighting prototype for the vscode extension.

nridge added a comment. Do you plan to support text decorations other than color, e.g. bold / underline / italic? Are users going to be able to tweak the color (and other decoration options) for specific highlightings in the VSCode Settings? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D65637: [clangd] [WIP] Semantic highlighting prototype for the vscode extension.

jvikstrom marked an inline comment as done. jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/TextMate.ts:20 +const split = scope.split('.'); +while(split.length > 0) { +split.splice(-1)

[PATCH] D65637: [clangd] [WIP] Semantic highlighting prototype for the vscode extension.

hokein added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/TextMate.ts:20 +const split = scope.split('.'); +while(split.length > 0) { +split.splice(-1) jvikstrom wrote: > I'm pretty sure

[PATCH] D65637: [clangd] [WIP] Semantic highlighting prototype for the vscode extension.

jvikstrom updated this revision to Diff 213015. jvikstrom added a comment. Fix matching logic on TM scopes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65637/new/ https://reviews.llvm.org/D65637 Files:

[PATCH] D65637: [clangd] [WIP] Semantic highlighting prototype for the vscode extension.

jvikstrom marked an inline comment as done. jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/TextMate.ts:20 +const split = scope.split('.'); +while(split.length > 0) { +split.splice(-1)

[PATCH] D65637: [clangd] [WIP] Semantic highlighting prototype for the vscode extension.

jvikstrom updated this revision to Diff 213013. jvikstrom added a comment. Fixed bug that made it impossible to find colors that were a perfect match to the scope we are looking for (ex: fixes function being color as functions and not as entity.name) Explanation for the bug: When adding the

[PATCH] D65637: [clangd] [WIP] Semantic highlighting prototype for the vscode extension.

jvikstrom updated this revision to Diff 213011. jvikstrom added a comment. Readded guard against rules without scopes that somehow disappeared. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65637/new/ https://reviews.llvm.org/D65637 Files:

[PATCH] D65637: [clangd] [WIP] Semantic highlighting prototype for the vscode extension.

jvikstrom created this revision. jvikstrom added reviewers: hokein, sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Contains all the functionality for the highlighting, is going to get cleaned up a lot though.