[PATCH] D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

raj.khem added a comment. In D65699#1662915 , @dalias wrote: > That's a separate issue of clang having a slight types-ABI mismatch with some > 32-bit archs whose original ABIs used `long` instead of `int` for `wchar_t`. > The wrong header order makes it

[PATCH] D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

hans added a comment. In D65699#1662936 , @MaskRay wrote: > @hans Can this be put on your list of things for 9.0.1? I searched for > `[meta] 9.0.1` on bugs.llvm.org but can't find a release blocker bug so I > have to bother you directly... Right, the

[PATCH] D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

MaskRay added a subscriber: hans. MaskRay added a comment. @hans Can this be put on your list of things for 9.0.1? I searched for `[meta] 9.0.1` on bugs.llvm.org but can't find a release blocker bug so I have to bother you directly... Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

dalias added a comment. That's a separate issue of clang having a slight types-ABI mismatch with some 32-bit archs whose original ABIs used `long` instead of `int` for `wchar_t`. The wrong header order makes it quickly apparent, but these are independent; wrong header order is still wrong and

[PATCH] D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

raj.khem added a comment. one issue I now see is that when we have some thing like static const struct { const wchar_t *name; int (*func)(EditLine *, int, const wchar_t **); } cmds[] = { { L"bind", map_bind}, { L"echotc",

[PATCH] D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

raj.khem added a comment. Can we bring this to 9.x release branch as well please ? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65699/new/ https://reviews.llvm.org/D65699 ___ cfe-commits mailing list

[PATCH] D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

This revision was automatically updated to reflect the committed changes. Closed by commit rL367981: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65699/new/ https://reviews.llvm.org/D65699 ___ cfe-commits

[PATCH] D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

dalias added a comment. It's not just infeasible; it's impossible by design. musl's headers do not support any contract with compiler-provided versions of the std headers, and won't. Attempting to use them in place of the libc ones is unsupported usage and will periodically break.

[PATCH] D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

phosek added a comment. This looks reasonable to me; I'd prefer to clean up Clang's internal headers to be compatible with both FreeBSD's and musl's standard headers as suggested in http://lists.llvm.org/pipermail/llvm-dev/2019-August/134353.html, but I'm not sure how feasible or doable that

[PATCH] D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

dalias added a comment. Just chiming in to confirm that the requested change is correct for musl. musl does not support use/mixing of compiler-provided std headers with its headers, and intentionally has no mechanism for communicating with such headers as to which types have already been

[PATCH] D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

MaskRay created this revision. MaskRay added reviewers: dalias, phosek, rsmith. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. On a musl-based Linux distribution, stdalign.h stdarg.h stdbool.h stddef.h stdint.h stdnoreturn.h are expected to be provided by musl