This revision was automatically updated to reflect the committed changes.
Closed by commit rL368546: [clangd] Highlighting auto variables as the deduced
type. (authored by jvikstrom, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:143
+ const auto Deduced = AT->getDeducedType();
+ if (Deduced.isNull())
+return true;
jvikstrom updated this revision to Diff 214373.
jvikstrom added a comment.
Removed ending whitespace on a line.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65996/new/
https://reviews.llvm.org/D65996
Files:
jvikstrom updated this revision to Diff 214372.
jvikstrom marked 3 inline comments as done.
jvikstrom added a comment.
Address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65996/new/
https://reviews.llvm.org/D65996
Files:
hokein added inline comments.
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:153
+// "auto" keyword other than using an offset.
+Loc = Loc.getLocWithOffset(9);
+ Deduced.getTypePtr()->dump();
The heuristic using here is
jvikstrom updated this revision to Diff 214319.
jvikstrom added a comment.
Finished comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65996/new/
https://reviews.llvm.org/D65996
Files:
clang-tools-extra/clangd/SemanticHighlighting.cpp
jvikstrom created this revision.
jvikstrom added reviewers: hokein, ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay.
Herald added a project: clang.
jvikstrom updated this revision to Diff 214319.
jvikstrom added a comment.
Finished comment.
Done in
