[PATCH] D66042: [analyzer] Analysis: Silence checkers

Szelethus added a comment. In D66042#1655119 , @sylvestre.ledru wrote: > @Charusso This probably should be added to the release notes: > https://clang.llvm.org/docs/ReleaseNotes.html#static-analyzer > and detailed in the doc. > Please let me know if

[PATCH] D66042: [analyzer] Analysis: Silence checkers

sylvestre.ledru added a comment. @Charusso This probably should be added to the release notes: https://clang.llvm.org/docs/ReleaseNotes.html#static-analyzer and detailed in the doc. Please let me know if you need help! Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D66042: [analyzer] Analysis: Silence checkers

This revision was automatically updated to reflect the committed changes. Closed by commit rL369078: [analyzer] Analysis: Silence checkers (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Charusso added a comment. Thanks for the reviews! Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +AnOpts.getRegisteredCheckers(/*IncludeExperimental=*/true); +

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Charusso updated this revision to Diff 215518. Charusso marked 10 inline comments as done. Charusso added a comment. - Rebased. - Added the remaining FIXME. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66042/new/ https://reviews.llvm.org/D66042 Files:

[PATCH] D66042: [analyzer] Analysis: Silence checkers

NoQ added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +AnOpts.getRegisteredCheckers(/*IncludeExperimental=*/true); +std::vector Packages = +

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Szelethus added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +AnOpts.getRegisteredCheckers(/*IncludeExperimental=*/true); +std::vector Packages = +

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Szelethus added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +AnOpts.getRegisteredCheckers(/*IncludeExperimental=*/true); +std::vector Packages = +

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Charusso added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +AnOpts.getRegisteredCheckers(/*IncludeExperimental=*/true); +std::vector Packages = +

[PATCH] D66042: [analyzer] Analysis: Silence checkers

NoQ added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +AnOpts.getRegisteredCheckers(/*IncludeExperimental=*/true); +std::vector Packages = +

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Charusso added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +AnOpts.getRegisteredCheckers(/*IncludeExperimental=*/true); +std::vector Packages = +

[PATCH] D66042: [analyzer] Analysis: Silence checkers

NoQ accepted this revision. NoQ added a comment. Guys, thank you so much for working on establishing consensus on this change. //*bows*// CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66042/new/ https://reviews.llvm.org/D66042 ___

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Szelethus added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +AnOpts.getRegisteredCheckers(/*IncludeExperimental=*/true); +std::vector Packages = +

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. You know what, I argued that we should use configs because this flag is incomplete. So I shouldn't be all up and down that it isn't. LGTM! CHANGES SINCE LAST ACTION

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Szelethus added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +AnOpts.getRegisteredCheckers(/*IncludeExperimental=*/true); +std::vector Packages = +

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Charusso marked 2 inline comments as done. Charusso added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Szelethus added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +AnOpts.getRegisteredCheckers(/*IncludeExperimental=*/true); +std::vector Packages = +

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Szelethus added a comment. I swear this is my last objection :) As soon as this is settled, I'll accept. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Szelethus added a comment. Now that I had ever more time to think about this patch, I see a great potential in it for development use, for example, we could silence a checker before splitting it up to see whether we could disable it altogether or really having to go through the process of

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Charusso updated this revision to Diff 215159. Charusso marked 4 inline comments as done. Charusso added a comment. - Rainbow Butterfly Unicorn Kitty CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66042/new/ https://reviews.llvm.org/D66042

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:468-502 void CheckerRegistry::validateCheckerOptions() const { for (const auto : AnOpts.Config) { StringRef SuppliedChecker; StringRef SuppliedOption;

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:392 +StringRef, RawSilencedCheckers, "silence-checkers", +"A semicolon separated list of checker and package names to silence.", "") + Hmm, maybe we

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Szelethus added a comment. Thanks!!! Please note that BugReporter.cpp (especially the parts you touched) just got refactored extensively, so you'll need to rebase on master. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:192 /// Pair of checker name

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Charusso added a comment. I realized that it is meaningless what separator we use to list the checkers, so I have picked `;`. The `,` is limited to the `analyzer-config` list. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:192-197 + /// Pair of checker

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Charusso updated this revision to Diff 215103. Charusso marked 4 inline comments as done. Charusso retitled this revision from "[analyzer] Analysis: "Disable" core checkers" to "[analyzer] Analysis: Silence checkers". Charusso edited the summary of this revision. Charusso set the repository for