This revision was automatically updated to reflect the committed changes.
jvikstrom marked 3 inline comments as done.
Closed by commit rL368563: [clangd] Remove highlightings coming from non
topLevelDecls from included files. (authored by jvikstrom, committed by ).
Herald added a project: LLVM.
hokein accepted this revision.
hokein added inline comments.
Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:236
+// topLevelDecls. (example: method declarations being included from another
+// file for a class) from another file)
+if
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM. Great example for the test case! It will definitely stay valid even if we
fix all problems caused by RecursiveASTVisitor!
Repository:
rG LLVM Github Monorepo
CHANGES
jvikstrom created this revision.
jvikstrom added reviewers: hokein, ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay.
Herald added a project: clang.
It is possible to write include code from other files so that the decls from
there do not become
