This revision was automatically updated to reflect the committed changes.
Closed by commit rL373275: Fix Driver/modules.cpp test to work when build
directory name contains .s (authored by tstellar, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed
dyung accepted this revision.
dyung added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66176/new/
https://reviews.llvm.org/D66176
___
tstellar marked an inline comment as done.
tstellar added inline comments.
Comment at: clang/test/Driver/modules.cpp:19
+// CHECK-COMPILE-SAME: {{ -o }}
+// CHECK-COMPILE-SAME: module{{2*}}.{{pcm.o|s}}
// CHECK-COMPILE-SAME: -x pcm
dyung wrote:
> I'm not sure
tstellar updated this revision to Diff 05.
tstellar added a comment.
Don't check .s suffix.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66176/new/
https://reviews.llvm.org/D66176
Files:
clang/test/Driver/modules.cpp
Index:
mgorny added a comment.
Ping. This is a really silly issue, and one that could be fixed trivially, so
it'd be really nice to actually fix it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66176/new/
https://reviews.llvm.org/D66176
dyung added a comment.
Taking a step back and thinking about this, the compile command uses "-S", but
explicitly specifies the output file to be "%t/module.pcm.o" (even though it is
generating an assembly file instead of an object file), could we change the
test to just check for "-o
tstellar updated this revision to Diff 214960.
tstellar added a comment.
Another attempt to fix this that depends less on the build directory.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66176/new/
https://reviews.llvm.org/D66176
Files:
dyung added a comment.
It's probably a pathological case, but wouldn't this still fail if the build
directory contained ".s" followed by a space in the name? Something like
"build-foo.s bar"?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
tstellar created this revision.
tstellar added reviewers: dyung, rsmith, hansw.
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D66176
Files:
clang/test/Driver/modules.cpp
Index: clang/test/Driver/modules.cpp
