This revision was automatically updated to reflect the committed changes.
Closed by commit rG28d38a25e963: Remove std::shared_ptr::allocate_shared
(authored by zoecarver).
Changed prior to commit:
https://reviews.llvm.org/D66178?vs=245918=246599#toc
Repository:
rG LLVM Github Monorepo
ldionne accepted this revision.
ldionne added a comment.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66178/new/
https://reviews.llvm.org/D66178
___
cfe-commits mailing list
zoecarver added a comment.
@ldionne friendly ping. This patch now //only// removes
`std::shared_ptr::allocate_shared`. Should be an easy change. And I think we
fixed @phosek's issue by breaking `__hold2.get()->get()` into a variable so
that compilers that parse args backwards still work here.
zoecarver updated this revision to Diff 245918.
zoecarver added a comment.
- Use __create_with_control_block in allocate_shared
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66178/new/
https://reviews.llvm.org/D66178
Files:
zoecarver updated this revision to Diff 245907.
zoecarver edited the summary of this revision.
zoecarver added a comment.
Herald added projects: clang, libc++.
Herald added a subscriber: cfe-commits.
- Remove std::shared_ptr::allocate_shared
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
zoecarver updated this revision to Diff 245908.
zoecarver added a comment.
- Remove std::shared_ptr::allocate_shared
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66178/new/
https://reviews.llvm.org/D66178
Files:
libcxx/include/memory
Index: