[PATCH] D66215: [clangd] Print qualifiers of out-of-line definitions in document outline

2019-08-14 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:106 + +/// Returns a nested name specifier if \p ND refers to a an out-of-line +/// definition. hokein wrote: > `if .. out-of-line definition` seems a bit confusing, I think here w

[PATCH] D66215: [clangd] Print qualifiers of out-of-line definitions in document outline

2019-08-14 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL368842: [clangd] Print qualifiers of out-of-line definitions in document outline (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prio

[PATCH] D66215: [clangd] Print qualifiers of out-of-line definitions in document outline

2019-08-14 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 215090. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Rename the helper function - Remove mention of 'out-of-line definition' from a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D66215: [clangd] Print qualifiers of out-of-line definitions in document outline

2019-08-14 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/AST.cpp:106 + +/// Returns a nested name specifier if \p ND refers to a an out-of-line +/// definition. `if .. out-

[PATCH] D66215: [clangd] Print qualifiers of out-of-line definitions in document outline

2019-08-14 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. ilya-biryukov added a reviewer: hokein. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. To improve the UX around navigating and searching through the results. Repository: rG LLVM Github Monorepo https://review