This revision was automatically updated to reflect the committed changes.
Closed by commit rL371080: [DebugInfo] Add debug location to stubs generated by
CGDeclCXX and mark them as… (authored by aganea, committed by ).
Changed prior to commit:
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm with the GlobalArrayDestructor name.
Comment at: include/clang/AST/GlobalDecl.h:34
AtExit,
+ GlobalDestructor
};
Maybe we should rename this
rnk added a comment.
I'm trying to figure out what exactly the new GlobalDestructor thing is. :)
It's not clear to me why we ever emit `__cxx_global_array_dtor` in the MS ABI.
We always call it directly from the `?__F` atexit helper stub instead of
registering it, so we really don't need it at
aganea marked an inline comment as done.
aganea added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:3581
+llvm::DILocalScope *PrevScope =
+!LexicalBlockStack.empty()
+? dyn_cast(LexicalBlockStack.back())
aganea wrote:
> rnk
aganea added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:3581
+llvm::DILocalScope *PrevScope =
+!LexicalBlockStack.empty()
+? dyn_cast(LexicalBlockStack.back())
rnk wrote:
> Is it OK to look up the lexical block stack at this
aganea updated this revision to Diff 218515.
aganea marked 2 inline comments as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66328/new/
https://reviews.llvm.org/D66328
Files:
include/clang/AST/GlobalDecl.h
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDeclCXX.cpp
rnk added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:3581
+llvm::DILocalScope *PrevScope =
+!LexicalBlockStack.empty()
+? dyn_cast(LexicalBlockStack.back())
Is it OK to look up the lexical block stack at this point? The
aganea updated this revision to Diff 217968.
aganea retitled this revision from "[DebugInfo] Add debug location to dynamic
atexit destructor" to "[DebugInfo] Add debug location to stubs generated by
CGDeclCXX and mark them as artificial".
aganea added a comment.
More tagging functions as
