This revision was automatically updated to reflect the committed changes.
Closed by commit rL371839: [ASTImporter] Add development internals docs
(authored by martong, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews
a_sidorin accepted this revision.
a_sidorin added a comment.
This revision is now accepted and ready to land.
Thank you!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66336/new/
https://reviews.llvm.org/D66336
___
martong added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66336/new/
https://reviews.llvm.org/D66336
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
martong marked 2 inline comments as done.
martong added inline comments.
Comment at: clang/docs/InternalsManual.rst:1470
+*templated* class (the ``CXXRecordDecl``) of a ``ClassTemplateDecl`` with
+``ClassTemplateDecl::getTemplatedDec()``. And we can get back a pointer of the
+"de
martong updated this revision to Diff 217171.
martong added a comment.
- Fix typo: getTemplatedDec -> getTemplatedDecl
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66336/new/
https://reviews.llvm.org/D66336
Files:
clang/docs/InternalsManual.rst
a_sidorin added inline comments.
Comment at: clang/docs/InternalsManual.rst:1470
+*templated* class (the ``CXXRecordDecl``) of a ``ClassTemplateDecl`` with
+``ClassTemplateDecl::getTemplatedDec()``. And we can get back a pointer of the
+"described" class template from the *templa
martong marked 6 inline comments as done.
martong added a comment.
Thanks for the review!
Comment at: clang/docs/InternalsManual.rst:1470
+*templated* class (the ``CXXRecordDecl``) of a ``ClassTemplateDecl`` with
+``ClassTemplateDecl::getTemplatedDec()``. And we can get back a
martong updated this revision to Diff 216579.
martong marked an inline comment as done.
martong added a comment.
- Address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66336/new/
https://reviews.llvm.org/D66336
Files:
clang/docs
balazske added inline comments.
Comment at: clang/docs/InternalsManual.rst:1569
+positive in-equivalencies otherwise. We must not allow having two (or more)
+independent redeclaration chains of structurally equivalent declarations.
+
It can be mentioned that the
a_sidorin added a comment.
Hello Gabor,
This doc will become extremely useful for new developers. Thank you for dumping
this sacred knowledge!
Comment at: clang/docs/InternalsManual.rst:1470
+*templated* class (the ``CXXRecordDecl``) of a ``ClassTemplateDecl`` with
+``ClassTem
martong created this revision.
martong added reviewers: a_sidorin, shafik, teemperor, gamesh411, balazske,
dkrupp.
Herald added subscribers: cfe-commits, Szelethus, rnkovacs.
Herald added a reviewer: a.sidorin.
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
https://reviews.
11 matches
Mail list logo