[PATCH] D66378: [clang-doc] Fix casting not working in gcc 5.4.0

2019-08-16 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett added a comment. LGTM, for posterity Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66378/new/ https://reviews.llvm.org/D66378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66378: [clang-doc] Fix casting not working in gcc 5.4.0

2019-08-16 Thread Diego Astiazarán via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL369182: [clang-doc] Fix casting not working in gcc 5.4.0 (authored by DiegoAstiazaran, committed by ). Herald added a

[PATCH] D66378: [clang-doc] Fix casting not working in gcc 5.4.0

2019-08-16 Thread Diego Astiazarán via Phabricator via cfe-commits
DiegoAstiazaran created this revision. DiegoAstiazaran added a project: clang-tools-extra. An implicit cast of std::string to llvm::SmallString<> was breaking GCC 5.4.0 builder. A pair using llvm::SmallString<> now uses std::string. https://reviews.llvm.org/D66378 Files: