This revision was automatically updated to reflect the committed changes.
Closed by commit rL369402: win: Enable /Zc:twoPhase by default if targeting
MSVC 2017 update 3 or newer (authored by nico, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed
hans accepted this revision.
hans added a comment.
Nice! Please include a mention in docs/ReleaseNotes.rst :-)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66394/new/
https://reviews.llvm.org/D66394
___
cfe-commits mailing list
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm! I can't believe we didn't notice this for a year. Not long ago a Firefox
developer filed a bug for a crash with `-fdelayed-template-parsing`, and if
this works for them, we won't have to
thakis created this revision.
thakis added a reviewer: hans.
MSVC 2017 update 3 (_MSC_VER 1911) enables /Zc:twoPhase by default, and
so should clang-cl:
https://docs.microsoft.com/en-us/cpp/build/reference/zc-twophase
clang-cl takes the MSVC version it emulates from the -fmsc-version flag,
or if
