mgorny added inline comments.
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:467
+ErrorOr Objcopy = sys::findProgramByName(
+"llvm-objcopy", sys::path::parent_path(BundlerExecutable));
+if (!Objcopy) {
This is broken for run
This revision was automatically updated to reflect the committed changes.
Closed by commit rGed153ef044fd: [Clang][Bundler] Use llvm-objcopy for creating
fat object files (authored by sdmitriev).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66485/ne
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66485/new/
https://reviews.llvm.org/D66485
___
cfe-commits ma
sdmitriev marked an inline comment as done.
sdmitriev added inline comments.
Comment at: clang/test/Driver/clang-offload-bundler.c:233
+// RUN: clang-offload-bundler -type=o
-targets=host-%itanium_abi_triple,openmp-powerpc64le-ibm-linux-gnu,openmp-x86_64-pc-linux-gnu
-inputs=%t
ABataev added inline comments.
Comment at: clang/test/Driver/clang-offload-bundler.c:233
+// RUN: clang-offload-bundler -type=o
-targets=host-%itanium_abi_triple,openmp-powerpc64le-ibm-linux-gnu,openmp-x86_64-pc-linux-gnu
-inputs=%t.o,%t.tgt1,%t.tgt2 -outputs=%t.bundle3.o -###
sdmitriev marked an inline comment as done.
sdmitriev added inline comments.
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:485
+"=" + InputFileNames[I]));
+ObjcopyArgs.push_back(InputFileNames[HostInputIndex]);
+
ABataev added inline comments.
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:485
+"=" + InputFileNames[I]));
+ObjcopyArgs.push_back(InputFileNames[HostInputIndex]);
+ObjcopyArgs.push_back(OutputFileNames.front())
sdmitriev added a comment.
Any feedback?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66485/new/
https://reviews.llvm.org/D66485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
sdmitriev created this revision.
sdmitriev added a reviewer: ABataev.
Herald added subscribers: cfe-commits, abrachet, mgorny.
Herald added a reviewer: alexshap.
Herald added a reviewer: jdoerfert.
Herald added a project: clang.
clang-offload-bundler currently uses partial linking for creating fat
