[PATCH] D66492: [Clang][CodeGen] set alias linkage on QualType

nickdesaulniers added a comment. In D66492#2350947 , @iajbar wrote: > Clang crashes when calling getLLVMLinkageVarDefinition() in > EmitAliasDefinition() when compiling this testcase: > enum a_type { a , b, c}; > typedef enum a_type b_type; > void foo(b_t

[PATCH] D66492: [Clang][CodeGen] set alias linkage on QualType

nickdesaulniers added a comment. In D66492#2350947 , @iajbar wrote: > Clang crashes when calling getLLVMLinkageVarDefinition() in > EmitAliasDefinition() when compiling this testcase: > enum a_type { a , b, c}; > typedef enum a_type b_type; > void foo(b_t

[PATCH] D66492: [Clang][CodeGen] set alias linkage on QualType

iajbar added a comment. Clang crashes when calling getLLVMLinkageVarDefinition() in EmitAliasDefinition() when compiling this testcase: enum a_type { a , b, c}; typedef enum a_type b_type; void foo(b_type x, enum a_type y){} void bar(b_type x, enum b_type y) __attribute__ ((alias ("foo"))); Decl

[PATCH] D66492: [Clang][CodeGen] set alias linkage on QualType

nickdesaulniers added a comment. @leonardchan thanks for the report, would you mind reviewing: https://reviews.llvm.org/D66622? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66492/new/ https://reviews.llvm.org/D66492 ___

[PATCH] D66492: [Clang][CodeGen] set alias linkage on QualType

leonardchan added a comment. I think this patch might be causing some test failures on our mac bots: FAIL: Clang :: CodeGen/alias.c (2014 of 15397) TEST 'Clang :: CodeGen/alias.c' FAILED Script: -- : 'RUN: at line 2'; /b/s/w/ir/k/recipe_clea

[PATCH] D66492: [Clang][CodeGen] set alias linkage on QualType

This revision was automatically updated to reflect the committed changes. Closed by commit rL369705: [Clang][CodeGen] set alias linkage on QualType (authored by nickdesaulniers, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[PATCH] D66492: [Clang][CodeGen] set alias linkage on QualType

nickdesaulniers updated this revision to Diff 216697. nickdesaulniers added a comment. - add unit test for function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66492/new/ https://reviews.llvm.org/D66492 Files: clang/lib/CodeGen/CodeGenModule.c

[PATCH] D66492: [Clang][CodeGen] set alias linkage on QualType

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I am not an expert on the alias attribute, but from what I can tell (with much thanks to @erichkeane for also helping to verify), this matches the GCC behavior. LGTM, but can you

[PATCH] D66492: [Clang][CodeGen] set alias linkage on QualType

nickdesaulniers created this revision. nickdesaulniers added a reviewer: rsmith. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. It seems that CodeGen was always using ExternalLinkage when emitting a GlobalDecl with __attribute__((alias)). This lea