jcai19 updated this revision to Diff 220393.
jcai19 added a comment.
Thanks for the confirmation!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66627/new/
https://reviews.llvm.org/D66627
Files:
gribozavr accepted this revision.
gribozavr added inline comments.
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:70
+- New :doc:`bugprone-posix-return
+ ` check.
jcai19 wrote:
> Eugene.Zelenko wrote:
> > Check is not new, just modified. Such check
jcai19 marked 3 inline comments as done.
jcai19 added inline comments.
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:70
+- New :doc:`bugprone-posix-return
+ ` check.
Eugene.Zelenko wrote:
> Check is not new, just modified. Such check should be after new
jcai19 updated this revision to Diff 217532.
jcai19 added a comment.
Fix format and test cases.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66627/new/
https://reviews.llvm.org/D66627
Files:
gribozavr accepted this revision.
gribozavr added a comment.
This revision is now accepted and ready to land.
LGTM with all comments addressed.
Comment at: clang-tools-extra/test/clang-tidy/bugprone-posix-return.cpp:169
int posix_fadvise(int fd, off_t offset, off_t len, int
Eugene.Zelenko added inline comments.
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:70
+- New :doc:`bugprone-posix-return
+ ` check.
Check is not new, just modified. Such check should be after new checks.
Comment at:
jcai19 updated this revision to Diff 217236.
jcai19 added a comment.
Update Release Notes and check documentation.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66627/new/
https://reviews.llvm.org/D66627
Files:
Eugene.Zelenko added a comment.
It'll be reasonable to mention changes in Release Notes and check documentation.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66627/new/
https://reviews.llvm.org/D66627