This revision was automatically updated to reflect the committed changes.
Closed by commit rL369914: [clang-tidy] TransformerClangTidyCheck: change
choice of location for… (authored by ymandel, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior
gribozavr accepted this revision.
gribozavr added a comment.
This revision is now accepted and ready to land.
I see, it all makes sense now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66676/new/
https://reviews.llvm.org/D66676
ymandel marked an inline comment as done.
ymandel added inline comments.
Comment at:
clang-tools-extra/unittests/clang-tidy/TransformerClangTidyCheckTest.cpp:106
+// argument, while the change spans only the argument AND there are two such
+// matches. Here, we expect a
ymandel updated this revision to Diff 217146.
ymandel added a comment.
fixed comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66676/new/
https://reviews.llvm.org/D66676
Files:
gribozavr added inline comments.
Comment at:
clang-tools-extra/unittests/clang-tidy/TransformerClangTidyCheckTest.cpp:106
+// argument, while the change spans only the argument AND there are two such
+// matches. Here, we expect a conflict between the two matches and the
ymandel created this revision.
ymandel added a reviewer: gribozavr.
Herald added a subscriber: xazax.hun.
Herald added a project: clang.
This patch changes the location specified to the
`ClangTidyCheck::diag()`. Currently, the beginning of the matched range is
used. This patch uses the beginning
