xazax.hun marked an inline comment as done.
xazax.hun added inline comments.
Comment at: clang/lib/Sema/SemaInit.cpp:6651
visitLocalsRetainedByReferenceBinding(Path, Arg, RK_ReferenceBinding,
-Visit);
+
mgehre added inline comments.
Comment at: clang/lib/Sema/SemaInit.cpp:6651
visitLocalsRetainedByReferenceBinding(Path, Arg, RK_ReferenceBinding,
-Visit);
+Visit, true);
else
--
xazax.hun abandoned this revision.
xazax.hun added a comment.
Committed in https://reviews.llvm.org/rG6379e5c8a441 due to it was urgent for
some users. Will address any comments post-commit.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66686/new/
https://reviews.llvm.org/D66686
___
xazax.hun updated this revision to Diff 216964.
xazax.hun added a comment.
- Added a test.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66686/new/
https://reviews.llvm.org/D66686
Files:
clang/include/clang/Basic/DiagnosticGroups.td
clang/include/clang/Basic/DiagnosticSemaKinds.td
xazax.hun updated this revision to Diff 216962.
xazax.hun added a comment.
- Add the actual diff.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66686/new/
https://reviews.llvm.org/D66686
Files:
clang/include/clang/Basic/DiagnosticGroups.td
clang/include/clang/Basic/DiagnosticSemaKi
xazax.hun created this revision.
xazax.hun added reviewers: rsmith, mgehre.
xazax.hun added a project: clang.
Herald added subscribers: llvm-commits, Szelethus, Charusso, gamesh411, jfb,
dkrupp, rnkovacs, hiraditya, javed.absar.
Herald added a project: LLVM.
This patch introduces quite a bit of p
