[PATCH] D66834: Driver tests: set `--sysroot=""` to support clang with `DEFAULT_SYSROOT`

This revision was automatically updated to reflect the committed changes. Closed by commit rL373147: Driver tests: set `--sysroot=` to support clang with `DEFAULT_SYSROOT` (authored by sepavloff, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D66834: Driver tests: set `--sysroot=""` to support clang with `DEFAULT_SYSROOT`

broadwaylamb added a comment. Can someone please commit this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66834/new/ https://reviews.llvm.org/D66834 ___ cfe-commits mailing list

[PATCH] D66834: Driver tests: set `--sysroot=""` to support clang with `DEFAULT_SYSROOT`

sepavloff accepted this revision. sepavloff added a comment. This revision is now accepted and ready to land. In D66834#1685921 , @broadwaylamb wrote: > In D66834#1685260 , @sepavloff wrote: > > > In

[PATCH] D66834: Driver tests: set `--sysroot=""` to support clang with `DEFAULT_SYSROOT`

broadwaylamb added a comment. In D66834#1685260 , @sepavloff wrote: > In D66834#1653334 , @broadwaylamb > wrote: > > > In D66834#1652756 , @compnerd > > wrote: > > > > > I

[PATCH] D66834: Driver tests: set `--sysroot=""` to support clang with `DEFAULT_SYSROOT`

sepavloff added a comment. In D66834#1653334 , @broadwaylamb wrote: > In D66834#1652756 , @compnerd wrote: > > > I think that this is pretty easy to forget. Fortunately, last argument > > wins. Why not sink

[PATCH] D66834: Driver tests: set `--sysroot=""` to support clang with `DEFAULT_SYSROOT`

broadwaylamb added a comment. In D66834#1652756 , @compnerd wrote: > I think that this is pretty easy to forget. Fortunately, last argument wins. > Why not sink this into the `%clang` substitution in lit? That ensures that > we run with an empty

[PATCH] D66834: Driver tests: set `--sysroot=""` to support clang with `DEFAULT_SYSROOT`

compnerd added a comment. I think that this is pretty easy to forget. Fortunately, last argument wins. Why not sink this into the `%clang` substitution in lit? That ensures that we run with an empty sysroot and then when the test needs to adjust the sysroot, it can do so explicitly.

[PATCH] D66834: Driver tests: set `--sysroot=""` to support clang with `DEFAULT_SYSROOT`

broadwaylamb updated this revision to Diff 217991. broadwaylamb added a comment. Remove unrelated change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66834/new/ https://reviews.llvm.org/D66834 Files: clang/test/Driver/darwin-sdkroot.c