[PATCH] D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

This revision was automatically updated to reflect the committed changes. Closed by commit rL372247: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd (authored by epilk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66856/new/ https://reviews.llvm.org/D66856 ___

[PATCH] D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

erik.pilkington added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66856/new/ https://reviews.llvm.org/D66856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

erik.pilkington added a comment. In D66856#116 , @aaron.ballman wrote: > The reflector discussion is still happening and there are issues with > ambiguities that we are pretty sure we want to correct. I've got a paper out > that touches on some of

[PATCH] D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

erik.pilkington updated this revision to Diff 219815. erik.pilkington marked 6 inline comments as done. erik.pilkington added a comment. Update the diagnostic text. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66856/new/ https://reviews.llvm.org/D66856 Files:

[PATCH] D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

aaron.ballman added a comment. In D66856#1650803 , @aaron.ballman wrote: > To me, actual problems at runtime belong in -Wformat and logical > inconsistencies that don't cause runtime problems belong in > -Wformat-pedantic. However, I think it's a

[PATCH] D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

erik.pilkington updated this revision to Diff 219598. erik.pilkington added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66856/new/ https://reviews.llvm.org/D66856 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/AST/Expr.cpp

[PATCH] D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

aaron.ballman added a comment. In D66856#1649721 , @erik.pilkington wrote: > In D66856#1648809 , @aaron.ballman > wrote: > > > I'm wondering whether this should even warn pedantically. There are no > > format

[PATCH] D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

erik.pilkington added a comment. In D66856#1648809 , @aaron.ballman wrote: > I'm wondering whether this should even warn pedantically. There are no format > specifiers that apply directly to a `_Bool` datatype, so the user is left > making a choice as

[PATCH] D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

aaron.ballman added a comment. I'm wondering whether this should even warn pedantically. There are no format specifiers that apply directly to a `_Bool` datatype, so the user is left making a choice as to what specifier fits best. I think `hhd` and `hhu` are both equally reasonable types, as

[PATCH] D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

erik.pilkington created this revision. erik.pilkington added reviewers: aaron.ballman, Nathan-Huckleberry. Herald added subscribers: ributzka, dexonsmith, jkorous. Herald added a project: clang. Instead, emit them under -Wformat-pedantic. This is particularly important for us because we have a