[PATCH] D66937: [clangd] Fix the stale documentation about background indexing.

2019-09-25 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL372825: [clangd] Fix the stale documentation about background indexing. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D66937: [clangd] Fix the stale documentation about background indexing.

2019-09-25 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 221687. hokein marked an inline comment as done. hokein added a comment. Fix a typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66937/new/ https://reviews.llvm.org/D66937 Files:

[PATCH] D66937: [clangd] Fix the stale documentation about background indexing.

2019-09-25 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/docs/clangd/Installation.rst:364 + amount of cores by passing the `-j=` flag; +- the index is saved to the ``.clangd/index``

[PATCH] D66937: [clangd] Fix the stale documentation about background indexing.

2019-09-24 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang-tools-extra/docs/clangd/Installation.rst:365 +- background indexing canb be disable by the ``--background-index=false`` flag; + if it is disabled, clangd doesn't have a global view of the whole project, it + only has a view on

[PATCH] D66937: [clangd] Fix the stale documentation about background indexing.

2019-09-24 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 221523. hokein marked 2 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66937/new/ https://reviews.llvm.org/D66937 Files:

[PATCH] D66937: [clangd] Fix the stale documentation about background indexing.

2019-09-24 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/docs/clangd/Installation.rst:363 -- Pass an experimental `-background-index` command line argument. With - this feature enabled, clangd incrementally builds an index of projects - that you work on and uses the

[PATCH] D66937: [clangd] Fix the stale documentation about background indexing.

2019-09-24 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang-tools-extra/docs/clangd/Installation.rst:363 -- Pass an experimental `-background-index` command line argument. With - this feature enabled, clangd incrementally builds an index of projects - that you work on and uses the

[PATCH] D66937: [clangd] Fix the stale documentation about background indexing.

2019-09-24 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 221508. hokein marked 8 inline comments as done. hokein added a comment. Herald added a subscriber: usaxena95. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66937/new/

[PATCH] D66937: [clangd] Fix the stale documentation about background indexing.

2019-09-24 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 221509. hokein added a comment. fix a typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66937/new/ https://reviews.llvm.org/D66937 Files: clang-tools-extra/docs/clangd/Installation.rst Index:

[PATCH] D66937: [clangd] Fix the stale documentation about background indexing.

2019-08-29 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a subscriber: sammccall. kadircet added a comment. Thanks for updating this! Pinging @sammccall since he is also working on writing some release docs, might be helpful to bring this to your attention. Comment at:

[PATCH] D66937: [clangd] Fix the stale documentation about background indexing.

2019-08-29 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66937 Files: clang-tools-extra/docs/clangd/Installation.rst