[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong added a comment. 2nd attempt to fix the windows build errors: 372646 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66951/new/ https://reviews.llvm.org/D66951 ___ cfe-commits mailing list

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong added a comment. Trying to fix in svn commit 372633. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66951/new/ https://reviews.llvm.org/D66951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

Thanks, for reaching out to me. I am looking into it. Gabor On Mon, Sep 23, 2019 at 5:44 PM Simon Pilgrim via Phabricator < revi...@reviews.llvm.org> wrote: > RKSimon added a comment. > > @martong This is failing on windows buildbots: >

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

RKSimon added a comment. @martong This is failing on windows buildbots: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/19808 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66951/new/ https://reviews.llvm.org/D66951

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

This revision was automatically updated to reflect the committed changes. Closed by commit rL372564: [ASTImporter][NFC] Add comprehensive tests for ODR violation handling strategies (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong added inline comments. Comment at: clang/unittests/AST/ASTImporterODRStrategiesTest.cpp:274 +// There may be a hidden fwd spec decl before a function spec decl. +if (auto *PrevF = dyn_cast(ImportedD)) { + if (PrevF->getTemplatedKind() ==

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong updated this revision to Diff 220338. martong marked 2 inline comments as done. martong added a comment. - PrevF->ImportedF, remove braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66951/new/ https://reviews.llvm.org/D66951 Files:

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterODRStrategiesTest.cpp:274 +// There may be a hidden fwd spec decl before a function spec decl. +if (auto *PrevF = dyn_cast(ImportedD)) { + if (PrevF->getTemplatedKind() ==

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong added a comment. I have reorganized the tests to group the ones which test ODR violation strategy independent behaviour. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66951/new/ https://reviews.llvm.org/D66951

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong updated this revision to Diff 220130. martong added a comment. - Reorganize ODRStrategy independent behaviour tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66951/new/ https://reviews.llvm.org/D66951 Files:

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong marked 3 inline comments as done. martong added inline comments. Comment at: clang/unittests/AST/ASTImporterODRStrategiesTest.cpp:118 + template + constexpr T X; + )"; shafik wrote: > shafik wrote: > > Note this is not well-formed b/c it

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong updated this revision to Diff 220104. martong marked an inline comment as done. martong added a comment. - Initialize the variable template in test - Clean up tests for fun templates and for specializations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

shafik added inline comments. Comment at: clang/unittests/AST/ASTImporterODRStrategiesTest.cpp:151 +}; + +template martong wrote: > balazske wrote: > > `FunctionTemplate` and `FunctionTemplateSpec` are missing? > Yes, because `FunctionTemplates` overload with

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

shafik added inline comments. Comment at: clang/unittests/AST/ASTImporterODRStrategiesTest.cpp:118 + template + constexpr T X; + )"; shafik wrote: > Note this is not well-formed b/c it is not initialized, [see >

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

shafik added inline comments. Comment at: clang/unittests/AST/ASTImporterODRStrategiesTest.cpp:118 + template + constexpr T X; + )"; Note this is not well-formed b/c it is not initialized, [see godbolt](https://godbolt.org/z/8xvFwh)

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong marked 3 inline comments as done. martong added a comment. In D66951#1660886 , @balazske wrote: > OK > Probably the `ClassTemplateSpec` can not be handled in liberal way because > the AST data structure for template specializations do not allow

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

balazske added a comment. OK Probably the `ClassTemplateSpec` can not be handled in liberal way because the AST data structure for template specializations do not allow multiple instances with same argument values? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong marked 6 inline comments as done. martong added inline comments. Comment at: clang/unittests/AST/ASTImporterODRStrategiesTest.cpp:36 + static constexpr auto *Definition = "void X(int a) {}"; + static constexpr auto *ConflictingDefinition = "void X(double a) {}"; +

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterODRStrategiesTest.cpp:36 + static constexpr auto *Definition = "void X(int a) {}"; + static constexpr auto *ConflictingDefinition = "void X(double a) {}"; + BindableMatcher getPattern() {

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong updated this revision to Diff 218625. martong added a comment. - Fix wrong file comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66951/new/ https://reviews.llvm.org/D66951 Files: clang/unittests/AST/ASTImporterODRStrategiesTest.cpp

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterODRStrategiesTest.cpp:1 +//===- unittest/AST/ASTImporterTest.cpp - AST node import test ===// +// Change the file name here? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong updated this revision to Diff 217899. martong added a comment. - Fix copy error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66951/new/ https://reviews.llvm.org/D66951 Files: clang/unittests/AST/ASTImporterODRStrategiesTest.cpp

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong created this revision. martong added reviewers: shafik, a_sidorin, balazske. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs, mgorny. Herald added a reviewer: a.sidorin. Herald added a project: clang. martong updated this revision to Diff 217899. martong