[PATCH] D67030: ContentCache: Simplify by always owning the MemoryBuffer

2020-10-20 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG296314516d10: ContentCache: Simplify by always owning the MemoryBuffer (authored by dexonsmith). Herald added a project: clang. Changed prior to commit:

[PATCH] D67030: ContentCache: Simplify by always owning the MemoryBuffer

2020-10-20 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. ping In D67030#2331280 , @dexonsmith wrote: > Rebased on top of https://reviews.llvm.org/D89431 (the tests haven't finished > yet; I'll update if necessary, but this is pretty straightforward). (FTR, the tests passed as

[PATCH] D67030: ContentCache: Simplify by always owning the MemoryBuffer

2020-10-14 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith updated this revision to Diff 298257. dexonsmith edited the summary of this revision. dexonsmith added a comment. Rebased on top of https://reviews.llvm.org/D89431 (the tests haven't finished yet; I'll update if necessary, but this is pretty straightforward). CHANGES SINCE LAST

[PATCH] D67030: ContentCache: Simplify by always owning the MemoryBuffer

2020-10-06 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. ping: Besides rebasing, any concerns here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67030/new/ https://reviews.llvm.org/D67030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67030: ContentCache: Simplify by always owning the MemoryBuffer

2019-08-30 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith created this revision. dexonsmith added reviewers: arphaman, Bigcheese, rsmith. Herald added a subscriber: ributzka. This changes ContentCache::Buffer to use `std::unique_ptr` instead of the PointerIntPair. It drops the (mostly unused) `DoNotFree` bit in favour of creating a new,