[PATCH] D67112: [Sema] Introduce function reference conversion, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG825f80e111f2: [Sema] Introduce function reference conversion, NFC (authored by aaronpuchert). Changed prior to commit: https://reviews.llvm.org/D67112?vs=246862=306929#toc Repository: rG LLVM Github

[PATCH] D67112: [Sema] Introduce function reference conversion, NFC

rsmith added a comment. In D67112#2401110 , @aaronpuchert wrote: > In D67112#2398577 , @rsmith wrote: > >> Looks fine as far as it goes, but it looks like we're also missing a cast in >> function pointer

[PATCH] D67112: [Sema] Introduce function reference conversion, NFC

aaronpuchert added a comment. In D67112#2398577 , @rsmith wrote: > Looks fine as far as it goes, but it looks like we're also missing a cast in > function pointer initialization via function conversion: > [...] > > |-VarDecl 0x105143e8 col:8 p 'void

[PATCH] D67112: [Sema] Introduce function reference conversion, NFC

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks fine as far as it goes, but it looks like we're also missing a cast in function pointer initialization via function conversion: void f() noexcept; void (*p)() = f; results in

[PATCH] D67112: [Sema] Introduce function reference conversion, NFC

aaronpuchert added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67112/new/ https://reviews.llvm.org/D67112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67112: [Sema] Introduce function reference conversion, NFC

aaronpuchert added a comment. Ping. Maybe this change is too silly, but I think it's better to be precise and not muddle qualification conversions together with casting away `noexcept`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67112/new/

[PATCH] D67112: [Sema] Introduce function reference conversion, NFC

aaronpuchert added a comment. @rsmith, what do you think about this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67112/new/ https://reviews.llvm.org/D67112 ___ cfe-commits mailing list