[PATCH] D67358: [clangd] Implement semantic selections.

This revision was automatically updated to reflect the committed changes. Closed by commit rL371976: Implement semantic selections. (authored by usaxena95, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D67358: [clangd] Implement semantic selections.

usaxena95 updated this revision to Diff 220303. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Resolved comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67358/new/ https://reviews.llvm.org/D67358 Files:

[PATCH] D67358: [clangd] Implement semantic selections.

sammccall added a comment. In D67358#1670810 , @nridge wrote: > Which LSP feature is this related to? selectionRange: - https://github.com/microsoft/vscode-languageserver-node/blob/master/protocol/src/protocol.selectionRange.ts -

[PATCH] D67358: [clangd] Implement semantic selections.

nridge added a comment. Which LSP feature is this related to? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67358/new/ https://reviews.llvm.org/D67358 ___ cfe-commits mailing list

[PATCH] D67358: [clangd] Implement semantic selections.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! Please make sure you run clang-format (I think it'll add missing newlines at EOF) Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:22 +// Assumes

[PATCH] D67358: [clangd] Implement semantic selections.

usaxena95 updated this revision to Diff 220075. usaxena95 added a comment. Remove extraneous namespace comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67358/new/ https://reviews.llvm.org/D67358 Files:

[PATCH] D67358: [clangd] Implement semantic selections.

usaxena95 updated this revision to Diff 220074. usaxena95 added a comment. Minor changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67358/new/ https://reviews.llvm.org/D67358 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D67358: [clangd] Implement semantic selections.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:33 + if (!Offset) { +llvm::errs() << "Unable to convert postion to offset"; +return {}; sammccall wrote: > we use log() or elog() for this, make sure you include

[PATCH] D67358: [clangd] Implement semantic selections.

usaxena95 updated this revision to Diff 220071. usaxena95 marked 13 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67358/new/ https://reviews.llvm.org/D67358 Files:

[PATCH] D67358: [clangd] Implement semantic selections.

sammccall marked 3 inline comments as done. sammccall added a comment. Nice! Particularly: great tests. Only big thing is toHalfOpenFileRange should get you substantially better macro handling. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:18 +namespace { +void

[PATCH] D67358: [clangd] Implement semantic selections.

usaxena95 updated this revision to Diff 219386. usaxena95 added a comment. Create range only if it represents a valid file range. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67358/new/ https://reviews.llvm.org/D67358 Files: