[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ abandoned this revision. NoQ added a comment. Abandon in favor of splitting up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67422/new/ https://reviews.llvm.org/D67422 ___ cfe-commits mailing list c

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ reopened this revision. NoQ added a comment. Herald added a subscriber: manas. This patch hasn't landed yet (reverted every time due to circular dependencies(?)). I plan to split it up into smaller patches as I rebase because rebase is already very painful. Repository: rG LLVM Github Mon

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

aaron.ballman added inline comments. Comment at: clang/lib/Analysis/SarifPathDiagnosticConsumer.cpp:307 .Case(FULLNAME, HELPTEXT) #include "clang/StaticAnalyzer/Checkers/Checkers.inc" #undef CHECKER Szelethus wrote: > NoQ wrote: > > Szelethus wrote: > > > No

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ added inline comments. Comment at: clang/lib/Analysis/SarifPathDiagnosticConsumer.cpp:307 .Case(FULLNAME, HELPTEXT) #include "clang/StaticAnalyzer/Checkers/Checkers.inc" #undef CHECKER Szelethus wrote: > NoQ wrote: > > Szelethus wrote: > > > NoQ wrote: >

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG44b7cf2983b6: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis. (authored by dergachev.a). Ch

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

Szelethus added a subscriber: aaron.ballman. Szelethus added inline comments. Comment at: clang/lib/Analysis/SarifPathDiagnosticConsumer.cpp:307 .Case(FULLNAME, HELPTEXT) #include "clang/StaticAnalyzer/Checkers/Checkers.inc" #undef CHECKER NoQ wrote: > Szele

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ added inline comments. Comment at: clang/lib/Analysis/SarifPathDiagnosticConsumer.cpp:307 .Case(FULLNAME, HELPTEXT) #include "clang/StaticAnalyzer/Checkers/Checkers.inc" #undef CHECKER Szelethus wrote: > NoQ wrote: > > This thing still worries me but thi

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

Szelethus added a comment. In D67422#2216137 , @NoQ wrote: > I agree that there's something here and also that it's not that > urgent/critical to rename things at this point. It's not that people suffer > horribly from having to link to only some of thes

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

Szelethus accepted this revision. Szelethus added a comment. Unless anyone else objects, I'm happy to see this landed! Nice work! ^-^ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67422/new/ https://reviews.llvm.org/D67422 ___ cfe-commits mai

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

Szelethus added inline comments. Comment at: clang/lib/Analysis/SarifPathDiagnosticConsumer.cpp:307 .Case(FULLNAME, HELPTEXT) #include "clang/StaticAnalyzer/Checkers/Checkers.inc" #undef CHECKER NoQ wrote: > This thing still worries me but this definitely is

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ added inline comments. Comment at: clang/lib/Analysis/SarifPathDiagnosticConsumer.cpp:307 .Case(FULLNAME, HELPTEXT) #include "clang/StaticAnalyzer/Checkers/Checkers.inc" #undef CHECKER This thing still worries me but this definitely isn't a link-time dep

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ updated this revision to Diff 285417. NoQ added a comment. In D67422#2215371 , @Szelethus wrote: > The patch looks great. I guess the only remaining discussion remains as to > whether this should be in `libAnalysis`, or somewhere else. Here is my take

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

vsavchenko accepted this revision. vsavchenko added a comment. Awesome, looks great! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67422/new/ https://reviews.llvm.org/D67422 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

Szelethus added a comment. The patch looks great. I guess the only remaining discussion remains as to whether this should be in `libAnalysis`, or somewhere else. Here is my take: Since clang-tidy, CSA, and some other parts of the compiler (like uninitialized variable warnings) are static analyz

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ added inline comments. Comment at: clang/lib/Analysis/PlistHTMLPathDiagnosticConsumer.cpp:27-31 + createHTMLDiagnosticConsumer( + DiagOpts, C, std::string(llvm::sys::path::parent_path(Prefix)), PP, CTU); + createPlistMultiFileDiagnosticConsumer(DiagOpts, C, Prefix, PP,

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ updated this revision to Diff 283993. NoQ marked 2 inline comments as done. NoQ added a comment. Whoops fxd! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67422/new/ https://reviews.llvm.org/D67422 Files: clang/include/clang/Analysis/PathDiagnosticConsumers.def clang/include/cl

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

vsavchenko added inline comments. Comment at: clang/lib/Analysis/TextPathDiagnosticConsumer.cpp:1 //===--- TextDiagnostics.cpp - Text Diagnostics for Paths ---*- C++ -*-===// // TextPathDiagnosticConsumer.cpp? Comment at: clang/lib/Analy

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ updated this revision to Diff 283461. NoQ marked 2 inline comments as done. NoQ added a comment. Fxd. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67422/new/ https://reviews.llvm.org/D67422 Files: clang/include/clang/Analysis/PathDiagnosticConsumers.def clang/include/clang/Ana

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ added inline comments. Comment at: clang/lib/Analysis/PlistHTMLPathDiagnosticConsumer.cpp:25 +PathDiagnosticConsumerOptions DiagOpts, PathDiagnosticConsumers &C, +const std::string &prefix, const Preprocessor &PP, +const cross_tu::CrossTranslationUnitContext &CTU)

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

vsavchenko added a comment. Other than parameter names, it looks totally reasonable to me. Comment at: clang/lib/Analysis/HTMLPathDiagnosticConsumer.cpp:70 + const std::string &OutputDir, + const Preprocessor &pp, bool su

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

Szelethus added a comment. In D67422#2192407 , @NoQ wrote: > One bit that's not directly related but i decided to keep it from the > original patch was moving the plist-html diagnostic builder function into its > own file. That is a great call indeed.

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ added inline comments. Comment at: clang/include/clang/Analysis/PathDiagnosticConsumers.h:36 const Preprocessor &PP, \ const cross_tu::CrossTranslationUnitContext &CTU); +#include "clang/Analysis/PathDi

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ updated this revision to Diff 282798. NoQ marked an inline comment as done. NoQ added a reviewer: vsavchenko. NoQ added a comment. Herald added a subscriber: steakhal. And rebase. Addressed comments. With @Szelethus's refactoring work the patch actually looks much cleaner than it used to.

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

Szelethus added a comment. Herald added subscribers: ASDenysPetrov, martong. In D67422#1667079 , @NoQ wrote: > Casually rename > `ClangDiagPathDiagConsumer` to `TextDiagnostics` according to the lo

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

gribozavr added inline comments. Comment at: clang/include/clang/Analysis/PathDiagnosticConsumers.def:23 +ANALYSIS_DIAGNOSTICS(PLIST_HTML, "plist-html", "Output analysis results using HTML wrapped with Plists", createPlistHTMLDiagnosticConsumer) +ANALYSIS_DIAGNOSTICS(SARIF, "sar

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ updated this revision to Diff 219829. NoQ added a comment. Herald added a subscriber: mgorny. Unforget to actually move the consumer implementations to `libAnalysis`, not just their headers. Casually rename `ClangDiagPathDiagConsumer

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ added a comment. Hmm, does anybody want me to write an example tool that emits path diagnostics but doesn't link to `libStaticAnalyzer*`? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67422/new/ https://reviews.llvm.org/D67422

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/include/clang/Analysis/PathDiagnosticConsumers.h:37 const cross_tu::CrossTranslationUnitContext &CTU); -#include "clang/StaticAnalyzer/Core/Analyses.def" +#include "clang/Analysis/

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

gribozavr requested changes to this revision. gribozavr added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Analysis/PathDiagnosticConsumers.h:37 const cross_tu::CrossTranslationUnitContext &CTU); -#include "clang

[PATCH] D67422: [analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso, alexfh, gribozavr. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. NoQ added a parent r