This revision was automatically updated to reflect the committed changes.
Closed by commit rL371969: Change signature of __builtin_rotateright64 back to
unsigned (authored by karka, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
Looks good to me! (with comment)
Comment at: test/CodeGen/avr-builtins.c:3
+// Check that the parameter types match.
+// RUN: %clang_cc1 -triple avr-unknown-unknown
Ka-Ka updated this revision to Diff 220294.
Ka-Ka added a comment.
Herald added subscribers: Jim, dylanmckay.
Update testcases according to review comment.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67606/new/
https://reviews.llvm.org/D67606
Files:
hans added a comment.
A simpler way to test this might be to check for conversion warnings in the
existing clang/test/CodeGen/avr-builtins.c test, for example like as above. I
think that's better since it covers more of the signatures, e.g. the rotateleft
ones too.
diff --git
Ka-Ka created this revision.
Ka-Ka added a reviewer: efriedma.
Herald added a subscriber: kristina.
Herald added a project: clang.
The signature of __builtin_rotateright64 was by misstake changed from
unsigned to signed in r360863, this patch will change it back to
unsigned as intended.
This
