[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX added a comment. In D67613#1680176 , @uabelho wrote: > In D67613#1679879 , @xbolva00 wrote: > > > /srv/llvm-buildbot-srcatch/llvm-build-dir/clang-x86_64-debian-fast/llvm.src/tools/clang/tools/extra/modulariz

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

uabelho added a comment. In D67613#1680176 , @uabelho wrote: > In D67613#1679879 , @xbolva00 wrote: > > > /srv/llvm-buildbot-srcatch/llvm-build-dir/clang-x86_64-debian-fast/llvm.src/tools/clang/tools/extra/modulariz

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

uabelho added a comment. In D67613#1679879 , @xbolva00 wrote: > /srv/llvm-buildbot-srcatch/llvm-build-dir/clang-x86_64-debian-fast/llvm.src/tools/clang/tools/extra/modularize/Modularize.cpp:583:13: > warning: enumeration values 'lang_cxx_11' and 'lang_cxx

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

JDevlieghere added a comment. I reverted this in r372672 because it caused a test failure in LLDB: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/1748/ Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67613/new/ https://reviews.llvm.org/D67613 _

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

xbolva00 added a comment. /srv/llvm-buildbot-srcatch/llvm-build-dir/clang-x86_64-debian-fast/llvm.src/tools/clang/tools/extra/modularize/Modularize.cpp:583:13: warning: enumeration values 'lang_cxx_11' and 'lang_cxx_14' not handled in switch [-Wswitch] 1 warning generated. Repository: rL LLV

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

This revision was automatically updated to reflect the committed changes. Closed by commit rL372663: Support for DWARF-5 C++ language tags. (authored by adrian, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX added a comment. In D67613#1674597 , @aprantl wrote: > Please be sure the watch the lldb (and other debugger) bots after committing > this.. Could you please commit these changes. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX added a comment. In D67613#1674902 , @SouraVX wrote: > In D67613#1674597 , @aprantl wrote: > > > Please be sure the watch the lldb (and other debugger) bots after > > committing this.. > > > Thanks a lot!

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX added a comment. In D67613#1674597 , @aprantl wrote: > Please be sure the watch the lldb (and other debugger) bots after committing > this.. Thanks a lot! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67613/new/ https://reviews.llvm.o

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Please be sure the watch the lldb (and other debugger) bots after committing this.. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67613/new/ https://reviews.llvm.org/D67613

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX updated this revision to Diff 220613. SouraVX added a comment. Updated AST to use DWARF language enums. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67613/new/ https://reviews.llvm.org/D67613 Files: include/clang/AST/DeclCXX.h lib/AST/DeclPrinter.cpp lib/AST/JSONNodeDump

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX marked 2 inline comments as done. SouraVX added inline comments. Comment at: include/clang/AST/DeclCXX.h:2931 +lang_cxx_11 = /* DW_LANG_C_plus_plus_11 */ 0x001a, +lang_cxx_14 = /* DW_LANG_C_plus_plus_14 */ 0x0021 }; aprantl wrote: > SouraVX wro

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

aprantl added inline comments. Comment at: include/clang/AST/DeclCXX.h:2931 +lang_cxx_11 = /* DW_LANG_C_plus_plus_11 */ 0x001a, +lang_cxx_14 = /* DW_LANG_C_plus_plus_14 */ 0x0021 }; SouraVX wrote: > aprantl wrote: > > SouraVX wrote: > > > aprantl wrote

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX marked an inline comment as done. SouraVX added inline comments. Comment at: include/clang/AST/DeclCXX.h:2931 +lang_cxx_11 = /* DW_LANG_C_plus_plus_11 */ 0x001a, +lang_cxx_14 = /* DW_LANG_C_plus_plus_14 */ 0x0021 }; aprantl wrote: > SouraVX wro

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

aprantl added inline comments. Comment at: include/clang/AST/DeclCXX.h:2931 +lang_cxx_11 = /* DW_LANG_C_plus_plus_11 */ 0x001a, +lang_cxx_14 = /* DW_LANG_C_plus_plus_14 */ 0x0021 }; SouraVX wrote: > aprantl wrote: > > I understand that DWARF does not d

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX updated this revision to Diff 220472. SouraVX set the repository for this revision to rC Clang. SouraVX added a comment. Removed underscores from names. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67613/new/ https://reviews.llvm.org/D67613 Files: inc

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX updated this revision to Diff 220435. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67613/new/ https://reviews.llvm.org/D67613 Files: include/clang/AST/DeclCXX.h lib/AST/DeclPrinter.cpp lib/AST/JSONNodeDumper.cpp lib/AST/TextNodeDumper.cpp lib/CodeGen/CGDebugInfo.cpp

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX marked 3 inline comments as done. SouraVX added inline comments. Comment at: include/clang/AST/DeclCXX.h:2931 +lang_cxx_11 = /* DW_LANG_C_plus_plus_11 */ 0x001a, +lang_cxx_14 = /* DW_LANG_C_plus_plus_14 */ 0x0021 }; aprantl wrote: > I understan

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

aprantl added inline comments. Comment at: include/clang/AST/DeclCXX.h:2931 +lang_cxx_11 = /* DW_LANG_C_plus_plus_11 */ 0x001a, +lang_cxx_14 = /* DW_LANG_C_plus_plus_14 */ 0x0021 }; I understand that DWARF does not define a C++17 language constant, but

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX created this revision. SouraVX added reviewers: aprantl, dblaikie. SouraVX added a project: debug-info. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch provides support for DW_LANG_C_plus_plus_11, DW_LANG_C_plus_plus_14 tags in clang C++ frontend. Repos