[PATCH] D67635: Fix for stringized function-macro args continued across lines

2019-09-20 Thread Kousik Kumar via Phabricator via cfe-commits
kousikk added a comment. > I think you should obtain commit access for your future patches/commits. You > can follow the instructions here: > https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access Thanks, I've done that! Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D67635: Fix for stringized function-macro args continued across lines

2019-09-19 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL372360: Fix for stringized function-macro args continued across lines (authored by arphaman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D67635: Fix for stringized function-macro args continued across lines

2019-09-19 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. In D67635#1675606 , @kousikk wrote: > Thanks! I will need you to merge this one too! Sure, I will commit it today. I think you should obtain commit access for your future patches/commits. You can follow the instructions here:

[PATCH] D67635: Fix for stringized function-macro args continued across lines

2019-09-19 Thread Kousik Kumar via Phabricator via cfe-commits
kousikk added a comment. Thanks! I will need you to merge this one too! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67635/new/ https://reviews.llvm.org/D67635 ___ cfe-commits mailing list

[PATCH] D67635: Fix for stringized function-macro args continued across lines

2019-09-19 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67635/new/ https://reviews.llvm.org/D67635

[PATCH] D67635: Fix for stringized function-macro args continued across lines

2019-09-18 Thread Kousik Kumar via Phabricator via cfe-commits
kousikk added a comment. Ping on the review for this :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67635/new/ https://reviews.llvm.org/D67635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67635: Fix for stringized function-macro args continued across lines

2019-09-16 Thread Kousik Kumar via Phabricator via cfe-commits
kousikk created this revision. kousikk added a reviewer: arphaman. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. In case of certain #define'd macros, there's a space just before line continuation that the minimized-source lexer was missing to include,