[PATCH] D67651: [clangd] No ExtractFunction on empty selections.

2019-09-23 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. In D67651#1672489 , @hokein wrote: > fair enough, didn't notice that fix before, the testcase here probably > doesn't work after that patch. yes it shouldn't work after that one. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D67651: [clangd] No ExtractFunction on empty selections.

2019-09-17 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. In D67651#1672403 , @kadircet wrote: > this one is actually specific to vardecl's and has a pending fix in D66872 > > > I would rather wait for it to land, instead of adding another branch. WDYT?

[PATCH] D67651: [clangd] No ExtractFunction on empty selections.

2019-09-17 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added a comment. this one is actually specific to vardecl's and has a pending fix in D66872 I would rather wait for it to land, instead of adding another branch. WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D67651: [clangd] No ExtractFunction on empty selections.

2019-09-17 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67651 Files: clang-tools-extra/clangd/refactor/tweaks/