This revision was automatically updated to reflect the committed changes.
Closed by commit rL372617: [clangd] Simplify the callside of URI::resolve, NFC.
(authored by hokein, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Comment at: clang-tools-extra/clangd/FindSymbols.cpp:48
if (!Path) {
return llvm::make_error(
+formatv("Could not resolve path for URI '{0}'
hokein added inline comments.
Comment at: clang-tools-extra/clangd/FindSymbols.cpp:48
if (!Path) {
return llvm::make_error(
+formatv("Could not resolve path for URI '{0}' for symbol '{1}': {2}",
kadircet wrote:
> `return make_string_error(...` ?
>
hokein updated this revision to Diff 221326.
hokein marked 7 inline comments as done.
hokein added a comment.
address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67916/new/
https://reviews.llvm.org/D67916
Files:
clang-tools-extra/cla
kadircet requested changes to this revision.
kadircet added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tools-extra/clangd/index/BackgroundIndexLoader.cpp:30
+ if (!AbsolutePath) {
+elog("Failed to resolve URI {0}:", URI, AbsolutePath.ta
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Comment at: clang-tools-extra/clangd/FindSymbols.cpp:48
if (!Path) {
return llvm::make_error(
+formatv("Could not resolve path for URI '{0}'
hokein updated this revision to Diff 221320.
hokein added a comment.
remove an accident change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67916/new/
https://reviews.llvm.org/D67916
Files:
clang-tools-extra/clangd/CodeComplete.cpp
clang-too
hokein created this revision.
hokein added a reviewer: kadircet.
Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.
- Add a overrloded URI::resolve, which accepts a string URI;
- also fixed some callside that don't check the error;
Repo
