[PATCH] D68261: [clangd] Add "inline" keyword to prevent ODR-violations in DefineInline

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60834 tests passed, 0 failed and 726 were skipped. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or apply this patch

[PATCH] D68261: [clangd] Add "inline" keyword to prevent ODR-violations in DefineInline

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:1913 + + // Specializations needs to be marked "inline". + ExtraFiles["a.h"] = R"cpp( hokein wrote: > could you add a test case for partial template specializations?

[PATCH] D68261: [clangd] Add "inline" keyword to prevent ODR-violations in DefineInline

This revision was automatically updated to reflect the committed changes. Closed by commit rG087528a33178: [clangd] Add inline keyword to prevent ODR-violations in DefineInline (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D68261: [clangd] Add "inline" keyword to prevent ODR-violations in DefineInline

kadircet updated this revision to Diff 233751. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68261/new/ https://reviews.llvm.org/D68261 Files:

[PATCH] D68261: [clangd] Add "inline" keyword to prevent ODR-violations in DefineInline

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. I think we probably want to do the vice-versa thing (remove the inline keyword) in define-outline. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:373

[PATCH] D68261: [clangd] Add "inline" keyword to prevent ODR-violations in DefineInline

merge_guards_bot added a comment. Build result: pass - 60656 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D68261: [clangd] Add "inline" keyword to prevent ODR-violations in DefineInline

kadircet updated this revision to Diff 233081. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68261/new/ https://reviews.llvm.org/D68261 Files: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp

[PATCH] D68261: [clangd] Add "inline" keyword to prevent ODR-violations in DefineInline

merge_guards_bot added a comment. Build result: pass - 60290 tests passed, 0 failed and 732 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D68261: [clangd] Add "inline" keyword to prevent ODR-violations in DefineInline

kadircet updated this revision to Diff 230847. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68261/new/ https://reviews.llvm.org/D68261 Files: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp

[PATCH] D68261: [clangd] Add "inline" keyword to prevent ODR-violations in DefineInline

kadircet created this revision. kadircet added reviewers: ilya-biryukov, hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68261 Files: