[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan added a comment. In D68340#1720362 , @Yi-Hong.Lyu wrote: > Seems this commit broke the buildbot > http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/6806 @daltenty's patch rG201ed14aea8c

[PATCH] D68340: Add AIX toolchain and basic linker functionality

Yi-Hong.Lyu added a comment. Seems this commit broke the buildbot http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/6806 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68340/new/ https://reviews.llvm.org/D68340

[PATCH] D68340: Add AIX toolchain and basic linker functionality

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb6a27fc257f: Add AIX toolchain and basic linker functionality (authored by stevewan, committed by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan marked 2 inline comments as done. stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:59 + + auto getCrt0Basename = [, ] { +// Enable gprofiling when "-pg" is specified. jasonliu wrote: > nit: There is no need to capture

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan updated this revision to Diff 226304. stevewan added a comment. Capture local variable IsArch32Bit by value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68340/new/ https://reviews.llvm.org/D68340 Files:

[PATCH] D68340: Add AIX toolchain and basic linker functionality

jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. Aside from the nit comment that can be addressed when checkin. LGTM. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:59 + + auto getCrt0Basename = [, ] { +//

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan updated this revision to Diff 226170. stevewan added a comment. Avoid blank else block when assertion is off Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68340/new/ https://reviews.llvm.org/D68340 Files:

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan marked 3 inline comments as done. stevewan added inline comments. Comment at: clang/lib/Driver/CMakeLists.txt:33 ToolChains/Arch/X86.cpp + ToolChains/AIX.cpp ToolChains/Ananas.cpp jasonliu wrote: > Looks like this list is following alphabetical

[PATCH] D68340: Add AIX toolchain and basic linker functionality

jasonliu added inline comments. Comment at: clang/lib/Driver/CMakeLists.txt:33 ToolChains/Arch/X86.cpp + ToolChains/AIX.cpp ToolChains/Ananas.cpp Looks like this list is following alphabetical order here, which means we should probably put

[PATCH] D68340: Add AIX toolchain and basic linker functionality

Xiangling_L added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:35 + // Only support 32 and 64 bit + if (!IsArch32Bit && !IsArch64Bit) +llvm_unreachable("Unsupported bit width value"); stevewan wrote: > jasonliu wrote: > > Xiangling_L

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:35 + // Only support 32 and 64 bit + if (!IsArch32Bit && !IsArch64Bit) +llvm_unreachable("Unsupported bit width value"); jasonliu wrote: > Xiangling_L wrote: > > Is there any

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan updated this revision to Diff 225925. stevewan marked 8 inline comments as done. stevewan added a comment. Tidy code with lambda expression Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68340/new/ https://reviews.llvm.org/D68340 Files:

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan updated this revision to Diff 225631. stevewan marked 25 inline comments as done. stevewan added reviewers: jasonliu, Xiangling_L. stevewan added a comment. Fix periods at the end of comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D68340: Add AIX toolchain and basic linker functionality

jasonliu added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.h:19 + +/// aix -- Directly call system default and linker. +// TODO: Enable direct call to system default assembler. remove "and". Comment at:

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan updated this revision to Diff 225521. stevewan added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68340/new/ https://reviews.llvm.org/D68340 Files: clang/lib/Driver/CMakeLists.txt

[PATCH] D68340: Add AIX toolchain and basic linker functionality

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:1 +//===--- AIX.cpp - AIX ToolChain Implementations *- C++ -*-===// +// See Jason's comment about the line length. Comment at:

[PATCH] D68340: Add AIX toolchain and basic linker functionality

jasonliu added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:35 + // Only support 32 and 64 bit + if (!IsArch32Bit && !IsArch64Bit) +llvm_unreachable("Unsupported bit width value"); Xiangling_L wrote: > Is there any reason to use

[PATCH] D68340: Add AIX toolchain and basic linker functionality

Xiangling_L added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:38 + + if (!Args.hasArg(options::OPT_nostdlib)) { +CmdArgs.push_back("-e"); Test with Clangtana on terran, when no '-nostdlib' specified, since '-e' & '__start' are the

[PATCH] D68340: Add AIX toolchain and basic linker functionality

Xiangling_L added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:35 + // Only support 32 and 64 bit + if (!IsArch32Bit && !IsArch64Bit) +llvm_unreachable("Unsupported bit width value"); Is there any reason to use llvm_unreachable here? I

[PATCH] D68340: Add AIX toolchain and basic linker functionality

jasonliu added a comment. nit: We might want to add period consistently for all the comments in the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68340/new/ https://reviews.llvm.org/D68340 ___

[PATCH] D68340: Add AIX toolchain and basic linker functionality

jasonliu added a comment. Any reason we are testing library search path using libgcc.a? We could use any dummy path there, and upload a dummy archive library for the testing purpose. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:112 + +AIX::~AIX() {} + We

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan created this revision. Herald added subscribers: cfe-commits, jsji, jfb, kbarton, mgorny, nemanjai. Herald added a project: clang. This patch adds AIX toolchain infrastructure into driver, and enables AIX system linker invocation with some basic functionality support Repository: rG