[PATCH] D68410: [AttrDocs] document always_inline

This revision was automatically updated to reflect the committed changes. Closed by commit rGe75fec2b238f: [AttrDocs] document always_inline (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68410/new/

[PATCH] D68410: [AttrDocs] document always_inline

lebedev.ri resigned from this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Seems fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68410/new/ https://reviews.llvm.org/D68410

[PATCH] D68410: [AttrDocs] document always_inline

nickdesaulniers marked 4 inline comments as done. nickdesaulniers added a comment. @lebedev.ri would you mind re-reviewing when you have a chance? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68410/new/ https://reviews.llvm.org/D68410

[PATCH] D68410: [AttrDocs] document always_inline

nickdesaulniers updated this revision to Diff 309971. nickdesaulniers added a comment. s/MSDN/Microsoft Docs/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68410/new/ https://reviews.llvm.org/D68410 Files: clang/include/clang/Basic/Attr.td

[PATCH] D68410: [AttrDocs] document always_inline

aaron.ballman added a comment. LGTM aside from the minor wording nit from @ojeda. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68410/new/ https://reviews.llvm.org/D68410 ___ cfe-commits mailing list

[PATCH] D68410: [AttrDocs] document always_inline

ojeda added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5498 + +See also `the MSDN Inline docs`_, `the GCC Common Function Attribute docs`_, +and `the GCC Inline docs`_. MSDN is gone now, Microsoft Docs is the new one. Repository: rG

[PATCH] D68410: [AttrDocs] document always_inline

jdoerfert added a comment. LGTM Comment at: clang/include/clang/Basic/AttrDocs.td:4401 +disabled. Does not guarantee that inline substitution actually occurs. +}]; + let Heading = "always_inline"; nickdesaulniers wrote: > lebedev.ri wrote: > > jdoerfert

[PATCH] D68410: [AttrDocs] document always_inline

nickdesaulniers added a comment. Sorry, I should not have waiting this long to update this patch... Comment at: clang/include/clang/Basic/AttrDocs.td:4401 +disabled. Does not guarantee that inline substitution actually occurs. +}]; + let Heading = "always_inline";

[PATCH] D68410: [AttrDocs] document always_inline

nickdesaulniers updated this revision to Diff 309682. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - rebased, s/Inline/Inlining/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68410/new/

[PATCH] D68410: [AttrDocs] document always_inline

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. I think partial (but not wrong!) docs is better than no docs whatsoever, so i'd be inclined to proceed with this. I, too, not really convinced that actual explicit rules

[PATCH] D68410: [AttrDocs] document always_inline

dblaikie added a comment. > In D68410#1696411 , @joerg wrote: > >> I wonder if we should actually enumerate evil here, i.e. give the situations >> in which inlining actually fails. > > > Which is likely to change over time. I worry that enumerating

[PATCH] D68410: [AttrDocs] document always_inline

nickdesaulniers added a comment. In D68410#1694026 , @kristina wrote: > Also, I'm fairly certain `__forceinline` and `always_inline`, confusingly > enough differ in semantics, with `__forceinline` only being a stronger hint > on MSVC. Does clang

[PATCH] D68410: [AttrDocs] document always_inline

joerg added a comment. I wonder if we should actually enumerate evil here, i.e. give the situations in which inlining actually fails. As mentioned on IRC, I wonder if we shouldn't aim for the stronger semantics and at least warn by default of any situation that prevents always_inline from

[PATCH] D68410: [AttrDocs] document always_inline

kristina added a comment. Just linking relevant bug for the record: https://bugs.llvm.org/show_bug.cgi?id=43517 Also, I'm fairly certain `__forceinline` and `always_inline`, confusingly enough differ in semantics, with `__forceinline` only being a stronger hint on MSVC. Repository: rG

[PATCH] D68410: [AttrDocs] document always_inline

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4399-4400 + let Content = [{ +Hint that inline substitution should be attempted when optimizations are +disabled. Does not guarantee that

[PATCH] D68410: [AttrDocs] document always_inline

nickdesaulniers updated this revision to Diff 223088. nickdesaulniers marked 3 inline comments as done. nickdesaulniers added a comment. - add links - remove extra whitespace - rewording, split onto separate lines to ease code review - add spellings to heading Repository: rG LLVM Github

[PATCH] D68410: [AttrDocs] document always_inline

jdoerfert added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4401 +disabled. Does not guarantee that inline substitution actually occurs. +}]; + let Heading = "always_inline"; It is more than that. This would imply that with optimizations

[PATCH] D68410: [AttrDocs] document always_inline

ojeda added a comment. Note that the latest GCC docs (rather than 4.1.2) are at: https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html For reference, this was triggered from: https://lore.kernel.org/lkml/cakwvodm_gouedjayxtqctuvdl+9vwvfeofhv06mlmyva75c...@mail.gmail.com/

[PATCH] D68410: [AttrDocs] document always_inline

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4400 +Hint that inline substitution should be attempted when optimizations are +disabled. Does not guarantee that inline substitution actually occurs. +}]; It may make sense

[PATCH] D68410: [AttrDocs] document always_inline

lebedev.ri added a reviewer: aaron.ballman. lebedev.ri added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4394-4395 } + + +def AlwaysInlineDocs : Documentation { One too many lines Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D68410: [AttrDocs] document always_inline

jyknight added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4399-4400 + let Content = [{ +Hint that inline substitution should be attempted when optimizations are +disabled. Does not guarantee that inline substitution actually occurs. +}];

[PATCH] D68410: [AttrDocs] document always_inline

nickdesaulniers created this revision. nickdesaulniers added reviewers: chandlerc, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. GNU documentaion for always_inline: https://gcc.gnu.org/onlinedocs/gcc/Inline.html GNU documentation for function attributes: