This revision was automatically updated to reflect the committed changes.
Closed by commit rL373785: [clang] [cmake] Use add_clang_tool() to install all
tools (authored by mgorny, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
fair enough
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68429/new/
https://reviews.llvm.org/D68429
___
cfe-commits mailing list
mgorny added a comment.
Well, they were installed for me, and all of them certainly have `install()`
command right now. Not sure if there's some high magic making `install()`
implicitly not install stuff here ;-).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68429/new/
beanz added a comment.
Are these tools intended to be installed? I thought they were developer focused
tools. I don't think we should make install targets for things that the project
doesn't want to support publicly.
This also changes the behavior of the `install` target to include these extra
mgorny created this revision.
mgorny added reviewers: compnerd, phosek, smeenai, beanz, tstellar.
Switch clang-check, clang-extdef-mapping and clang-offload-bundler
to use add_clang_tool() rather than add_clang_executable() with a custom
install rule. This makes them
