[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch! I've committed on your behalf in 4de6b1586807285e20a5db6596519c2336a64568 . Repository: rCTE Clang Tools Extra CHANGES SINCE LAST

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

vladimir.plyashkun marked an inline comment as done. vladimir.plyashkun added a comment. In D68694#1711035 , @aaron.ballman wrote: > LGTM aside from a small nit. Thanks, fixed it! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

vladimir.plyashkun updated this revision to Diff 226101. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68694/new/ https://reviews.llvm.org/D68694 Files: clang-tools-extra/clang-tidy/hicpp/SignedBitwiseCheck.cpp

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a small nit. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:174 +- The :doc:`hicpp-signed-bitwise + ` now supports `IgnorePositiveIntegerLiterals` + option.

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM. But i was inactive for a long time, if @aaron.ballman accepts as well you can commit instantly. Otherwise please let the other people that commented some time to react. :)

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

vladimir.plyashkun added a comment. In D68694#1706204 , @JonasToth wrote: > > Do you know who is responsible for it? Because i haven't worked with > > documentation before and don't know what i need to do to update it. > > The files reside in

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

vladimir.plyashkun updated this revision to Diff 224976. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68694/new/ https://reviews.llvm.org/D68694 Files: clang-tools-extra/clang-tidy/hicpp/SignedBitwiseCheck.cpp

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

JonasToth added a comment. > Do you know who is responsible for it? Because i haven't worked with > documentation before and don't know what i need to do to update it. The files reside in `clang-tools-extra/docs/ReleaseNotes.rst` and

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

vladimir.plyashkun added a comment. In D68694#1705668 , @JonasToth wrote: > The new switch needs documentation as well, and maybe even a note in the > release notes (as it is publicly discussed as issue?). Do you know who is responsible for it? Because

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

vladimir.plyashkun updated this revision to Diff 224597. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68694/new/ https://reviews.llvm.org/D68694 Files: clang-tools-extra/clang-tidy/hicpp/SignedBitwiseCheck.cpp

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

vladimir.plyashkun marked 2 inline comments as done. vladimir.plyashkun added inline comments. Comment at: clang-tools-extra/clang-tidy/hicpp/SignedBitwiseCheck.cpp:23-24 +: ClangTidyCheck(Name, Context), + IgnorePositiveIntegerLiterals( +

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/hicpp/SignedBitwiseCheck.cpp:23-24 +: ClangTidyCheck(Name, Context), + IgnorePositiveIntegerLiterals( + Options.getLocalOrGlobal("IgnorePositiveIntegerLiterals", false)) {} +

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

vladimir.plyashkun marked an inline comment as done. vladimir.plyashkun added inline comments. Comment at: clang-tools-extra/clang-tidy/hicpp/SignedBitwiseCheck.cpp:23-24 +: ClangTidyCheck(Name, Context), + IgnorePositiveIntegerLiterals( +

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

JonasToth added a comment. The new switch needs documentation as well, and maybe even a note in the release notes (as it is publicly discussed as issue?). Otherwise I am fine with the changes! Comment at:

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/hicpp/SignedBitwiseCheck.cpp:23-24 +: ClangTidyCheck(Name, Context), + IgnorePositiveIntegerLiterals( + Options.getLocalOrGlobal("IgnorePositiveIntegerLiterals", false)) {} +

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

vladimir.plyashkun added a comment. @aaron.ballman @JonasToth Thanks, i agree too! I've prepared new revision with additional option to preserve old inspection behaviour. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68694/new/

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

vladimir.plyashkun updated this revision to Diff 224557. vladimir.plyashkun added a comment. Provide additional option to preserve current inspection behaviour Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68694/new/ https://reviews.llvm.org/D68694

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

JonasToth added a comment. In D68694#1701772 , @aaron.ballman wrote: > > In my opinion this check should be disabled in case of integer literals, > > since there are a lot of existing code (even in system libraries) where > > user can do nothing, e.g.: