[PATCH] D68767: [clang-format] NFC - Move functionality into functions to help code structure

MyDeveloperDay abandoned this revision. MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added a comment. Review comments regarding movign getInvalidBOM are addressed in D68914: [clang-format] Remove duplciate code from Invalid BOM detection

[PATCH] D68767: [clang-format] NFC - Move functionality into functions to help code structure

MyDeveloperDay marked 6 inline comments as done. MyDeveloperDay added a comment. I'll likely abandon this review when D68554: [clang-format] Proposal for clang-format to give compiler style warnings lands Comment at:

[PATCH] D68767: [clang-format] NFC - Move functionality into functions to help code structure

owenpan added inline comments. Comment at: clang/tools/clang-format/ClangFormat.cpp:245 +// Returns an invalid BOM +static const char *hasInValidBOM(StringRef BufStr) { + // Check to see if the buffer has a UTF Byte Order Mark (BOM). owenpan wrote: > This code

[PATCH] D68767: [clang-format] NFC - Move functionality into functions to help code structure

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, mitchell-stellar, owenpan. MyDeveloperDay added a project: clang-format. Herald added a project: clang. I don't think its the main()'s responsibility to be working out how to dump the config, or the format()'s