[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

erichkeane marked 2 inline comments as done. erichkeane added a comment. In D68824#1733621 , @hans wrote: > We hit this in V8 which is annotating some pointers as being 4GB-aligned. > Does anyone know what it would take to raise Clang's limit here? The

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

hans added a comment. We hit this in V8 which is annotating some pointers as being 4GB-aligned. Does anyone know what it would take to raise Clang's limit here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68824/new/ https://reviews.llvm.org/D68824

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:6067-6070 +// Alignment calculations can wrap around if it's greater than 2**28. +unsigned MaximumAlignment = +Context.getTargetInfo().getTriple().isOSBinFormatCOFF() ? 8192 +

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

erichkeane marked 5 inline comments as done. erichkeane added subscribers: majnemer, aaron.ballman. erichkeane added a comment. In D68824#1704942 , @rsmith wrote: > This seems to be missing a CodeGen test for what IR we generate on an > overly-large

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

rsmith added a comment. This seems to be missing a CodeGen test for what IR we generate on an overly-large alignment. (The warning says the alignment is ignored, but I don't see where you're actually doing anything different in that case when generating IR.) Comment at:

Re: [PATCH] D68824: Fix __builtin_assume_aligned with too large values.

Thanks! On the way home for the evening, so I'll fix it up tomorrow. On Oct 10, 2019 2:34 PM, Nico Weber via Phabricator wrote: thakis added a comment. Since you just left IRC, I reverted this in 374456 for now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68824/new/

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

thakis added a comment. Since you just left IRC, I reverted this in 374456 for now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68824/new/ https://reviews.llvm.org/D68824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

thakis added a comment. The new test fails on Windows: -- Testing: 16032 tests, 32 workers -- Testing: 0.. 10.. 20.. 30.. 40.. 50 FAIL: Clang :: Sema/builtin-assume-aligned.c (8862 of 16032) TEST 'Clang :: Sema/builtin-assume-aligned.c' FAILED

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

erichkeane updated this revision to Diff 224456. erichkeane added a comment. cant use llvm::Value in Sema without some linker issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68824/new/ https://reviews.llvm.org/D68824 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. LG, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68824/new/ https://reviews.llvm.org/D68824 ___ cfe-commits mailing

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

erichkeane updated this revision to Diff 224455. erichkeane marked 5 inline comments as done. erichkeane added a comment. Hal's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68824/new/ https://reviews.llvm.org/D68824 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

hfinkel added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2854 +def warn_assume_align_too_big : Warning<"alignments greater than 1 << 29 are " + "unsupported by LLVM">, InGroup; Should this be in the IgnoredAttributes group?

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

erichkeane updated this revision to Diff 224449. erichkeane added a comment. Remove unused code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68824/new/ https://reviews.llvm.org/D68824 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

erichkeane created this revision. erichkeane added reviewers: lebedev.ri, hfinkel, joey, jdoerfert. lebedev.ri added a comment. Thanks, i like it. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2058-2073 +/* void CodeGenFunction::EmitAlignmentAssumption(llvm::Value

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

lebedev.ri added a comment. Thanks, i like it. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:2058-2073 +/* void CodeGenFunction::EmitAlignmentAssumption(llvm::Value *PtrValue, QualType Ty, SourceLocation Loc,