[PATCH] D68876: [libTooling] Put all Transformer declarations in a single namespace.

ymandel added a comment. In D68876#1711576 , @aprantl wrote: > It looks like it's still failing: > http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/2649/console That line was fixed in the revision I mentioned: https://reviews.llvm.org/rL375003

[PATCH] D68876: [libTooling] Put all Transformer declarations in a single namespace.

aprantl added a comment. It looks like it's still failing: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/2649/console Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68876/new/ https://reviews.llvm.org/D68876

[PATCH] D68876: [libTooling] Put all Transformer declarations in a single namespace.

ymandel added a comment. This should be fixed by r375003. Please let me know if that's not the case. In D68876#1711227 , @aprantl wrote: > This broke the modular build since some symbols are now ambiguous within the > same Clang module.' > >

[PATCH] D68876: [libTooling] Put all Transformer declarations in a single namespace.

aprantl added a comment. This broke the modular build since some symbols are now ambiguous within the same Clang module.' http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/2646/consoleFull#25217323649ba4694-19c4-4d7e-bec5-911270d8a58c FAILED:

[PATCH] D68876: [libTooling] Put all Transformer declarations in a single namespace.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bb47cd8c30c: [libTooling] Put all Transformer declarations in a single namespace. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D68876: [libTooling] Put all Transformer declarations in a single namespace.

ymandel updated this revision to Diff 224653. ymandel added a comment. remove stray newline and include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68876/new/ https://reviews.llvm.org/D68876 Files:

[PATCH] D68876: [libTooling] Put all Transformer declarations in a single namespace.

ymandel updated this revision to Diff 224651. ymandel edited the summary of this revision. ymandel added a comment. fix using decl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68876/new/ https://reviews.llvm.org/D68876 Files:

[PATCH] D68876: [libTooling] Put all Transformer declarations in a single namespace.

ymandel updated this revision to Diff 224650. ymandel added a comment. moved all decls to clang::transformer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68876/new/ https://reviews.llvm.org/D68876 Files: