[PATCH] D68913: Adds fixit hints to the Wrange-loop-analysis

This revision was automatically updated to reflect the committed changes. Closed by commit rGf022a5a792fd: Adds fixit hints to the -Wrange-loop-analysis (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68913/new/

[PATCH] D68913: Adds fixit hints to the Wrange-loop-analysis

Mordante added a comment. In D68913#1787784 , @thakis wrote: > Mordante, do you need someone to land this for you? Thanks for the offer, but it's not required. I want to commit it once I fixed all issues that would be introduced by D68912

[PATCH] D68913: Adds fixit hints to the Wrange-loop-analysis

thakis added a comment. Mordante, do you need someone to land this for you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68913/new/ https://reviews.llvm.org/D68913 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68913: Adds fixit hints to the Wrange-loop-analysis

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68913/new/ https://reviews.llvm.org/D68913 ___ cfe-commits mailing

[PATCH] D68913: Adds fixit hints to the Wrange-loop-analysis

Mordante updated this revision to Diff 225782. Mordante added a comment. Undo the changes to the caret position as requested by @aaron.ballman . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68913/new/ https://reviews.llvm.org/D68913 Files: clang/include/clang/AST/Decl.h

[PATCH] D68913: Adds fixit hints to the Wrange-loop-analysis

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:2759 SemaRef.Context.getLValueReferenceType(E->getType().withConst()); -SemaRef.Diag(VD->getBeginLoc(), diag::note_use_type_or_non_reference) -<< NonReferenceType <<

[PATCH] D68913: Adds fixit hints to the Wrange-loop-analysis

Mordante created this revision. Mordante added reviewers: rsmith, rtrieu, xbolva00. Mordante added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68913 Files: clang/include/clang/AST/Decl.h clang/lib/AST/Decl.cpp clang/lib/Sema/SemaStmt.cpp