[PATCH] D68915: [clang][IFS] Escape mangled name in-order to not break llvm-ifs with names mangled using MS ABI

2019-10-14 Thread Puyan Lotfi via Phabricator via cfe-commits
plotfi added a comment. I see what went wrong. Will post a fix shortly. In D68915#1708297 , @thakis wrote: > On macOS symbols are prefixed with an underscore: > > Command Output (stderr): > -- >

[PATCH] D68915: [clang][IFS] Escape mangled name in-order to not break llvm-ifs with names mangled using MS ABI

2019-10-14 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. On macOS symbols are prefixed with an underscore: Command Output (stderr): -- /Users/thakis/src/llvm-project/clang/test/InterfaceStubs/object.c:5:16: error: CHECK-TAPI: expected string not found in input // CHECK-TAPI: "data" : { Type: Object, Size: 4 }

[PATCH] D68915: [clang][IFS] Escape mangled name in-order to not break llvm-ifs with names mangled using MS ABI

2019-10-14 Thread Puyan Lotfi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG76f9869bf200: [clang][IFS] Escape mangled names so MS ABI doesnt break YAML parsing. (authored by plotfi). Changed prior to commit: https://reviews.llvm.org/D68915?vs=224756=224879#toc Repository:

[PATCH] D68915: [clang][IFS] Escape mangled name in-order to not break llvm-ifs with names mangled using MS ABI

2019-10-12 Thread Puyan Lotfi via Phabricator via cfe-commits
plotfi created this revision. plotfi added reviewers: compnerd, cishida. Herald added a project: clang. Herald added a subscriber: cfe-commits. plotfi updated this revision to Diff 224756. Microsoft's ABI mangles names differently than Itanium and this breaks the LLVM yaml parser unless the name

[PATCH] D68915: [clang][IFS] Escape mangled name in-order to not break llvm-ifs with names mangled using MS ABI

2019-10-12 Thread Puyan Lotfi via Phabricator via cfe-commits
plotfi updated this revision to Diff 224756. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68915/new/ https://reviews.llvm.org/D68915 Files: lib/Frontend/InterfaceStubFunctionsConsumer.cpp test/InterfaceStubs/inline.c test/InterfaceStubs/object.c