[PATCH] D69186: Refactor DependencyScanningTool to its own file

2019-10-21 Thread Kousik Kumar via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfb042b094fda: Refactor DependencyScanningTool to its own file (authored by kousikk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69186/new/ https://review

[PATCH] D69186: Refactor DependencyScanningTool to its own file

2019-10-21 Thread Kousik Kumar via Phabricator via cfe-commits
kousikk updated this revision to Diff 225994. kousikk added a comment. Run clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69186/new/ https://reviews.llvm.org/D69186 Files: clang/include/clang/Tooling/DependencyScanning/DependencyScan

[PATCH] D69186: Refactor DependencyScanningTool to its own file

2019-10-21 Thread Michael Spencer via Phabricator via cfe-commits
Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM with style nit. I like that this decouples `DependencyScanningTool` from printing the results. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:105-107 +

[PATCH] D69186: Refactor DependencyScanningTool to its own file

2019-10-18 Thread Kousik Kumar via Phabricator via cfe-commits
kousikk created this revision. kousikk added reviewers: arphaman, jkorous, Bigcheese, dexonsmith. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. kousikk updated this revision to Diff 225667. kousikk added a comment. Lint fixes There's no behavior change - just movi

[PATCH] D69186: Refactor DependencyScanningTool to its own file

2019-10-18 Thread Kousik Kumar via Phabricator via cfe-commits
kousikk updated this revision to Diff 225667. kousikk added a comment. Lint fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69186/new/ https://reviews.llvm.org/D69186 Files: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTo