[PATCH] D69241: [clangd] Handle the missing constructor initializers in findExplicitReferences.

This revision was automatically updated to reflect the committed changes. Closed by commit rG13fc899cdecc: [clangd] Handle the missing constructor initializers in findExplicitReferences. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D69241: [clangd] Handle the missing constructor initializers in findExplicitReferences.

merge_guards_bot added a comment. Build result: fail - 59521 tests passed, 1 failed and 805 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69241: [clangd] Handle the missing constructor initializers in findExplicitReferences.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:677 if (const CXXCtorInitializer *CCI = N.get()) { - if (CCI->isBaseInitializer()) -return refInTypeLoc(CCI->getBaseClassLoc()); - ass

[PATCH] D69241: [clangd] Handle the missing constructor initializers in findExplicitReferences.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:677 if (const CXXCtorInitializer *CCI = N.get()) { - if (CCI->isBaseInitializer()) -return refInTypeLoc(CCI->getBaseClassLoc()); - assert(CCI->isAnyMemberInitializer())

[PATCH] D69241: [clangd] Handle the missing constructor initializers in findExplicitReferences.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:677 if (const CXXCtorInitializer *CCI = N.get()) { - if (CCI->isBaseInitializer()) -return refInTypeLoc(CCI->getBaseClassLoc()); - ass

[PATCH] D69241: [clangd] Handle the missing constructor initializers in findExplicitReferences.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:677 if (const CXXCtorInitializer *CCI = N.get()) { - if (CCI->isBaseInitializer()) -return refInTypeLoc(CCI->getBaseClassLoc()); - assert(CCI->isAnyMemberInitializer())

[PATCH] D69241: [clangd] Handle the missing constructor initializers in findExplicitReferences.

merge_guards_bot added a comment. Build result: fail - 59521 tests passed, 1 failed and 805 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69241: [clangd] Handle the missing constructor initializers in findExplicitReferences.

hokein added a comment. In D69241#1716787 , @ilya-biryukov wrote: > NIT: there's a typo in the revision title: should be **constructor**, not > **consturctor** Done. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp

[PATCH] D69241: [clangd] Handle the missing constructor initializers in findExplicitReferences.

hokein updated this revision to Diff 226013. hokein marked 2 inline comments as done. hokein added a comment. - fix some issues in the existing implementation; - add tests for base/delegating initializer; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org