[PATCH] D69298: [clangd] Define out-of-line initial apply logic

2019-12-04 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. ApplyTest fails on Windows; probably the usual delayed template parsing thing: http://45.33.8.238/win/3368/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69298/new/ https://reviews.llvm.org/D69298 _

[PATCH] D69298: [clangd] Define out-of-line initial apply logic

2019-12-03 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGce2189202245: [clangd] Define out-of-line initial apply logic (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69298/new/ https://revie

[PATCH] D69298: [clangd] Define out-of-line initial apply logic

2019-11-28 Thread pre-merge checks [bot] via Phabricator via cfe-commits
merge_guards_bot added a comment. Build result: FAILURE - Could not check out parent git hash "6a2d56e54fa4a2009787a605607b0df7fe16dd98". It was not found in the repository. Did you configure the "Parent Revision" in Phabricator properly? Trying to apply the patch to the master branch instead..

[PATCH] D69298: [clangd] Define out-of-line initial apply logic

2019-11-28 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 231382. kadircet marked an inline comment as done. kadircet added a comment. - Address comments - Better handling for macros and tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69298/new/ https://reviews.l

[PATCH] D69298: [clangd] Define out-of-line initial apply logic

2019-11-25 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:53 +// template keyword for templated functions. +// FIXME: This is shared with define inli

[PATCH] D69298: [clangd] Define out-of-line initial apply logic

2019-11-21 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 230437. kadircet added a comment. - Get rid of raw string literals inside macros Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69298/new/ https://reviews.llvm.org/D69298 Files: clang-tools-extra/clangd/refa

[PATCH] D69298: [clangd] Define out-of-line initial apply logic

2019-10-30 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 227108. kadircet marked 5 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69298/new/ https://reviews.llvm.org/D69298 Files: clang-tools-ex

[PATCH] D69298: [clangd] Define out-of-line initial apply logic

2019-10-30 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:55 + // Include template parameter list. + if (auto *FTD = FD->getDescribedFunctionTemplate()) +return FTD->getBeginLoc(); hokein wrote: > Could you confi

[PATCH] D69298: [clangd] Define out-of-line initial apply logic

2019-10-28 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:55 + // Include template parameter list. + if (auto *FTD = FD->getDescribedFunctionTemplate()) +return FTD->getBeginLoc(); Could you confirm the code handle

[PATCH] D69298: [clangd] Define out-of-line initial apply logic

2019-10-23 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 226134. kadircet marked an inline comment as done. kadircet added a comment. - Address comments - Handle template parameters when copying function and add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D692

[PATCH] D69298: [clangd] Define out-of-line initial apply logic

2019-10-23 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet marked 7 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:1574 + ExtraFiles["Test.cpp"] = ""; + EXPECT_EQ(apply("void fo^o() { return; }", &EditedFiles), "void foo() ;"); + EXPECT_THAT(EditedFiles,

[PATCH] D69298: [clangd] Define out-of-line initial apply logic

2019-10-23 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:59 +// different location. Contains both function signature and body. +llvm::Optional moveFunctionDef(const FunctionDecl *FD) { + auto &SM = FD->getASTContext().getSourceManager(

[PATCH] D69298: [clangd] Define out-of-line initial apply logic

2019-10-22 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 226046. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69298/new/ https://reviews.llvm.org/D69298 Files: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp clang-

[PATCH] D69298: [clangd] Define out-of-line initial apply logic

2019-10-22 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Initial implementation for apply logic, replaces function body with a semicolon in source location and cop