thakis added a comment.
ApplyTest fails on Windows; probably the usual delayed template parsing thing:
http://45.33.8.238/win/3368/step_7.txt
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69298/new/
https://reviews.llvm.org/D69298
_
This revision was automatically updated to reflect the committed changes.
Closed by commit rGce2189202245: [clangd] Define out-of-line initial apply
logic (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69298/new/
https://revie
merge_guards_bot added a comment.
Build result: FAILURE - Could not check out parent git hash
"6a2d56e54fa4a2009787a605607b0df7fe16dd98". It was not found in the repository.
Did you configure the "Parent Revision" in Phabricator properly? Trying to
apply the patch to the master branch instead..
kadircet updated this revision to Diff 231382.
kadircet marked an inline comment as done.
kadircet added a comment.
- Address comments
- Better handling for macros and tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69298/new/
https://reviews.l
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
looks good.
Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:53
+// template keyword for templated functions.
+// FIXME: This is shared with define inli
kadircet updated this revision to Diff 230437.
kadircet added a comment.
- Get rid of raw string literals inside macros
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69298/new/
https://reviews.llvm.org/D69298
Files:
clang-tools-extra/clangd/refa
kadircet updated this revision to Diff 227108.
kadircet marked 5 inline comments as done.
kadircet added a comment.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69298/new/
https://reviews.llvm.org/D69298
Files:
clang-tools-ex
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:55
+ // Include template parameter list.
+ if (auto *FTD = FD->getDescribedFunctionTemplate())
+return FTD->getBeginLoc();
hokein wrote:
> Could you confi
hokein added inline comments.
Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:55
+ // Include template parameter list.
+ if (auto *FTD = FD->getDescribedFunctionTemplate())
+return FTD->getBeginLoc();
Could you confirm the code handle
kadircet updated this revision to Diff 226134.
kadircet marked an inline comment as done.
kadircet added a comment.
- Address comments
- Handle template parameters when copying function and add tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D692
kadircet marked 7 inline comments as done.
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:1574
+ ExtraFiles["Test.cpp"] = "";
+ EXPECT_EQ(apply("void fo^o() { return; }", &EditedFiles), "void foo() ;");
+ EXPECT_THAT(EditedFiles,
hokein added inline comments.
Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:59
+// different location. Contains both function signature and body.
+llvm::Optional moveFunctionDef(const FunctionDecl *FD) {
+ auto &SM = FD->getASTContext().getSourceManager(
kadircet updated this revision to Diff 226046.
kadircet added a comment.
- Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69298/new/
https://reviews.llvm.org/D69298
Files:
clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp
clang-
kadircet created this revision.
kadircet added a reviewer: hokein.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
Initial implementation for apply logic, replaces function body with a
semicolon in source location and cop
14 matches
Mail list logo