ABataev added inline comments.
Comment at: clang/lib/Sema/SemaOpenMP.cpp:14926-14929
+ } else if (((SemaRef.getLangOpts().OpenMP >= 50 &&
+ DKind != OMPD_target_update) ||
+ SemaRef.getLangOpts().OpenMP < 50) &&
+
cchen updated this revision to Diff 229922.
cchen added a comment.
Add and fix test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69316/new/
https://reviews.llvm.org/D69316
Files:
clang/lib/Sema/SemaOpenMP.cpp
ABataev added a comment.
What about codegen tests?
Comment at: clang/test/OpenMP/target_update_ast_print.cpp:25
+ U marr[10][10][10];
+#pragma omp target update to(marr[2][0:2][0:2])
+
It seems to me, the tests are not updated. All non-contiguous tests must
cchen updated this revision to Diff 227174.
cchen added a comment.
Rebase and fix add OpenMP 50 guard
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69316/new/
https://reviews.llvm.org/D69316
Files:
clang/lib/Sema/SemaOpenMP.cpp
cchen updated this revision to Diff 227169.
cchen added a comment.
Remove the restriction rule for array section to another patch
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69316/new/
https://reviews.llvm.org/D69316
Files:
ABataev added inline comments.
Comment at: clang/lib/Sema/SemaOpenMP.cpp:14450
+ if (HasMeetPointer && !IsLastArraySection) {
+SemaRef.Diag(ELoc, diag::err_omp_pointer_type_not_last)
Ad the check for the version of OpenMP standard, it must be
cchen updated this revision to Diff 226067.
cchen added a comment.
Fix summary message
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69316/new/
https://reviews.llvm.org/D69316
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
cchen created this revision.
cchen added reviewers: ABataev, sfantao.
Herald added subscribers: cfe-commits, guansong.
Herald added a reviewer: jdoerfert.
Herald added a project: clang.
- Removed a restriction that list items for target update
directive must have contiguous storage.
- A
