[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

thakis added a comment. Hi, a whole bunch of cuda-related tests failed on windows with this in (http://45.33.8.238/win/32620/summary.html). Did you run check-clang before committing? I reverted this for now in 4874ff02417916cc9ff994b34abcb5e563056546

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa2fdf9d4d734: [hip][cuda] Enable extended lambda support on Windows. (authored by hliao). Changed prior to commit:

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good with one suggestion. Comment at: clang/include/clang/AST/ASTContext.h:540 llvm::MapVector MangleNumbers; llvm::MapVector StaticLocalNumbers;

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao added a comment. @rsmith, @rnk and @rjmccall, could you review the latest change addressing the memory usage issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/ https://reviews.llvm.org/D69322

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao added a comment. PING for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/ https://reviews.llvm.org/D69322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao updated this revision to Diff 320679. hliao added a comment. Revise comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/ https://reviews.llvm.org/D69322 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao updated this revision to Diff 320568. hliao added a comment. - Remove `DeviceManglingNumber` to reduce memory usage. - Add a table in ASTContext for device lambda mangling numbers if that lamba requires. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao updated this revision to Diff 320409. hliao added a comment. Rebase to the main branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/ https://reviews.llvm.org/D69322 Files: clang/include/clang/AST/DeclCXX.h

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

rjmccall added a comment. I agree that we should aim to avoid broad memory impact for uncommon features, and this seems to apply. Comment at: clang/include/clang/AST/DeclCXX.h:395-400 /// The number used to indicate this lambda expression for name /// mangling in

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

rnk added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:395-400 /// The number used to indicate this lambda expression for name /// mangling in the Itanium C++ ABI. unsigned ManglingNumber : 31; +/// The device side mangling number. +

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

tra added a comment. In D69322#2523058 , @tra wrote: > @hliao -- Can you take a look at > https://bugs.llvm.org/show_bug.cgi?id=48866. This patch may be relevant there. @rnk Reid, looks like this patch does fix a lambda mangling issue in CUDA on

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

tra added a comment. @hliao -- Can you take a look at https://bugs.llvm.org/show_bug.cgi?id=48866. This patch may be relevant there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/ https://reviews.llvm.org/D69322

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao added a comment. PING for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/ https://reviews.llvm.org/D69322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao added a comment. PING for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/ https://reviews.llvm.org/D69322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao added a comment. Looks like holidays are approaching, :). Anyway, it's really appreciated that you could review this patch to enable CUDA/HIP applications on Windows. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao added a comment. kindly PING for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/ https://reviews.llvm.org/D69322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:395-400 /// The number used to indicate this lambda expression for name /// mangling in the Itanium C++ ABI. unsigned ManglingNumber : 31; +/// The device side mangling number. +

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao updated this revision to Diff 227214. hliao marked an inline comment as done. hliao added a comment. simplify again following suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/ https://reviews.llvm.org/D69322 Files:

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

rnk added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:395-400 /// The number used to indicate this lambda expression for name /// mangling in the Itanium C++ ABI. unsigned ManglingNumber : 31; +/// The device side mangling number. +

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao updated this revision to Diff 227091. hliao added a comment. revise `MSHIPNumberingContext` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/ https://reviews.llvm.org/D69322 Files: clang/include/clang/AST/DeclCXX.h

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao marked 3 inline comments as done. hliao added inline comments. Comment at: clang/include/clang/AST/MangleNumberingContext.h:57-58 + + /// Has device mangle numbering context. + virtual bool hasDeviceMangleNumberingContext() const { return false; } + rnk

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

rnk added inline comments. Comment at: clang/include/clang/AST/MangleNumberingContext.h:57-58 + + /// Has device mangle numbering context. + virtual bool hasDeviceMangleNumberingContext() const { return false; } + It would be nicer if there were a single entry

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

tra added a reviewer: rnk. tra added a subscriber: rnk. tra added a comment. @rnk Reid, would you be the right person to look at the change on the Windows' side? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao added a comment. PING for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/ https://reviews.llvm.org/D69322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

rjmccall added a comment. Please don't ping for review after a single day. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/ https://reviews.llvm.org/D69322 ___ cfe-commits mailing list

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao added a comment. PING for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/ https://reviews.llvm.org/D69322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao created this revision. hliao added reviewers: rsmith, rjmccall, tra, yaxunl. Herald added a reviewer: martong. Herald added a reviewer: shafik. Herald added subscribers: cfe-commits, erik.pilkington. Herald added a project: clang. - On Windows, extended lambda has extra issues due to the