[PATCH] D69471: [Coverage] Revise format to reduce binary size

This revision was automatically updated to reflect the committed changes. Closed by commit rG99317124e1c7: [Coverage] Revise format to reduce binary size (authored by vsk). Changed prior to commit: https://reviews.llvm.org/D69471?vs=245756=247396#toc Repository: rG LLVM Github Monorepo

[PATCH] D69471: [Coverage] Revise format to reduce binary size

rnk accepted this revision. rnk added a comment. Sounds like a plan, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69471/new/ https://reviews.llvm.org/D69471 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69471: [Coverage] Revise format to reduce binary size

vsk updated this revision to Diff 245756. vsk added a comment. This revision is now accepted and ready to land. Get rid of multiple inheritance in the coverage::accessors namespace. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69471/new/ https://reviews.llvm.org/D69471 Files:

[PATCH] D69471: [Coverage] Revise format to reduce binary size

vsk planned changes to this revision. vsk added a comment. @rnk Thanks for chasing this down. I'll update the function record structs to use free functions instead of multiple inheritance. I don't plan on getting rid of the awkward method calls at this point. The coverage reader is still

[PATCH] D69471: [Coverage] Revise format to reduce binary size

rnk added a comment. In D69471#1884043 , @dexonsmith wrote: > In D69471#1883912 , @rnk wrote: > > > Everything is off-by-one because the empty bases are not zero sized. The > > MSVC record layout algorithm is just

[PATCH] D69471: [Coverage] Revise format to reduce binary size

dexonsmith added a comment. In D69471#1883912 , @rnk wrote: > Everything is off-by-one because the empty bases are not zero sized. The MSVC > record layout algorithm is just different in this area. =/ Do all the MSVCs we support building with support

[PATCH] D69471: [Coverage] Revise format to reduce binary size

rnk added a comment. Compiling with -fdump-record-layouts revealed the problem: *** Dumping AST Record Layout 0 | struct llvm::coverage::CovMapFunctionRecordV3 0 | struct llvm::coverage::accessors::FuncHashAndDataSize (base) (empty) 1 | struct

[PATCH] D69471: [Coverage] Revise format to reduce binary size

vsk updated this revision to Diff 244790. vsk added a comment. Rebase. Sorry this hasn't seen any update: at this point in our release cycle I've had to put this on the back burner. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69471/new/ https://reviews.llvm.org/D69471 Files:

[PATCH] D69471: [Coverage] Revise format to reduce binary size

rnk added a comment. I haven't forgotten about this, even though it's been two months. Hopefully I get to it soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69471/new/ https://reviews.llvm.org/D69471

[PATCH] D69471: [Coverage] Revise format to reduce binary size

rnk added a comment. I have a Windows build directory and am motivated to debug this. I'll try to do it tomorrow, but I have a couple of other deadlines so I can't make a very firm promise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69471/new/

[PATCH] D69471: [Coverage] Revise format to reduce binary size

vsk added a comment. Sorry for the delay here. An update: I tested this patch with a sanitized build on a Linux install, but could not reproduce the "malformed coverage data" errors seen on the Windows bots. At this point, it seems likely that there is a bug in CoverageMappingReader (this

[PATCH] D69471: [Coverage] Revise format to reduce binary size

vsk reopened this revision. vsk marked an inline comment as done. vsk added a comment. This revision is now accepted and ready to land. I reverted this due to failures on Windows that I did not encounter in local testing. I suspect that there's an error in the coverage parsing logic, as the

[PATCH] D69471: [Coverage] Revise format to reduce binary size

efriedma added inline comments. Comment at: llvm/lib/ProfileData/Coverage/CoverageMappingWriter.cpp:53-56 +Error E = +zlib::compress(FilenamesStr, CompressedStr, zlib::BestSizeCompression); +if (E) + llvm_unreachable("Unexpected failure in zlib::compress");

[PATCH] D69471: [Coverage] Revise format to reduce binary size

This revision was automatically updated to reflect the committed changes. Closed by commit rGe18531595bba: [Coverage] Revise format to reduce binary size (authored by vsk). Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Repository: rG LLVM Github